Skip to content
Snippets Groups Projects

Draft: ZFS support

Closed Thomas Eberhardt requested to merge ed209/devtools:zfs_support into master

Add support for using ZFS clones for chroots. I use this with my modified version of the AUR clean-chroot-manager to build packages for my local repo. I don't use archbuild or makerepropkg but my modified version of clean-chroot-manager contains equivalent code to delete the chroots.

Shouldn't change anything if used on a non-ZFS system. zfs-utils doesn't need to be added to the optional depends for the devtools package, since it is a hard dependency for the ZFS kernel module.

Also contains some small typo fixes and TAB cleanups.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hello, thanks for your contribution to devtools :tada:

    A few high-level comments before this eventually get's a proper review:

    • We as Maintainers are not using ZFS since our infrastructure runs on BTRFS and the only place I have ZFS is on my NAS. So this would mean that we can't really support it ourselves and should this be merged you (or others that use ZFS) would probably need to take care of maintaining it.
    • We're using conventional commits, see the README fore some examples: https://gitlab.archlinux.org/archlinux/devtools#commit-messages
    • the function names for the current BTRFS related functions would probably need to be renamed to be clear (i.e. subvolume_delete_recursive could also be referring to ZFS subvols)
  • Oops... Sorry, I obviously didn't read the README. I'll need to redo this.

    I don't know if I could keep on maintaining the ZFS support. Perhaps just keep it as my local patches...

    I mark this as a draft for now, to see if it gets more comments.

  • Thomas Eberhardt marked this merge request as draft

    marked this merge request as draft

  • I've redesigned this to make the support for snapshotting file systems modular.

Please register or sign in to reply
Loading