Skip to content
Snippets Groups Projects
Wiktor Kwapisiewicz's avatar
opened issue #274 "Add support for using `sop` for signing and verification" at Arch Linux / devtools
Yashasvi's avatar
closed issue #273 "Creating a proper Web-Page for the Mirror-list" at Arch Linux / devtools
Jelle van der Waa's avatar
commented on issue #273 "Creating a proper Web-Page for the Mirror-list" at Arch Linux / devtools

The official issue tracker for the Arch Linux website lives here. BTW we have two mirror overview lists, here and mirrorstatus. The mirror list gen...

Yashasvi's avatar
commented on issue #273 "Creating a proper Web-Page for the Mirror-list" at Arch Linux / devtools

Can I get assigned to this issue?...

Yashasvi's avatar
opened issue #273 "Creating a proper Web-Page for the Mirror-list" at Arch Linux / devtools
Josephine Pfeiffer's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

hi @anthraxx could you please take a look at the changes I made when you have a moment?

Estela's avatar
commented on merge request !299 "makechrootpkg: allow pass "-s" to arch-nspawn to not run setarch" at Arch Linux / devtools

Hello, sorry for the delay. the reason is same as 5b9c06d2 ....

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

Thanks for looking into contributing here. Please adjust some small things:...

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

We shouldn't be using random unrelated fixtures and initializing git repos inside them for creating a state on the fly we aim to test against. prob...

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

like posted in the repo.sh review, this should all just live inside configure.sh hence this is the only file that should be included and the config...

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

This check has no test coverage, if we add tests we should actually cover failure paths.

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

This breaks the expectations that you can configure an AUR repository when promoting a package

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

This breaks the expectations that you can simply configure a local git init repo

Levente Polyak's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

all these changes must be moved into the configure.sh file, this breaks the CLI API and you are not able to pass in any paths

Morten Linderud's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

LGTM

Morten Linderud's avatar
approved merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools
Christian Heusel's avatar
opened issue #272 "Introduce check to see if chroot version file exists" at Arch Linux / devtools
Josephine Pfeiffer's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

I changed the test to check the exit code instead

Jakub Klinkovský's avatar
commented on issue #270 "Check whether remote commits exist before releasing" at Arch Linux / devtools

Makes sense now, but later we may want to actually release in a non-main branch (when ports are a thing)....

Morgan Adamiec's avatar
commented on merge request !303 "[GL#257] add pkgctl repo sanity check" at Arch Linux / devtools

Should we be testing the error messages in tests? I find it bad practise imo.