Pacman keyring init

Fixes #383 (closed)

Looks good, but the keyring generated in the installation process (/etc/pacman.d/gnupg/) also needs to be deleted.

resolved all threads

added 1 commit

• 7102d90e - use "one-liner" syntax

Compare with previous version

added 1 commit

• 7ab7da7e - remove generated keyring in the installation process

Compare with previous version

resolved all threads

added 1 commit

• f6e79a1d - move pacman-init.service to files

Compare with previous version

resolved all threads

added 1 commit

• 82569abe - use copy instead of template

Compare with previous version

added 1 commit

• 97988515 - make sure /etc/machine-id is absent

Compare with previous version

resolved all threads

I tested !493 (97988515) with this Packer patch and it works (hurray):

[root@archlinux-packer ~]# GNUPGHOME=/etc/pacman.d/gnupg gpg --list-keys
gpg: WARNING: unsafe permissions on homedir '/etc/pacman.d/gnupg'
/etc/pacman.d/gnupg/pubring.gpg
-------------------------------
pub   rsa4096 2021-10-13 [SC]
      3C300146BEE36D53831B9749162D17EFAEFADBCC
uid           [ultimate] Pacman Keyring Master Key <pacman@localhost>
[...]
...reinstall...
[root@archlinux-packer ~]# GNUPGHOME=/etc/pacman.d/gnupg gpg --list-keys
gpg: WARNING: unsafe permissions on homedir '/etc/pacman.d/gnupg'
/etc/pacman.d/gnupg/pubring.gpg
-------------------------------
pub   rsa4096 2021-10-13 [SC]
      5FCD3CEE4EB1FA2FBA6A5DF6C3E53487115B3CC3
uid           [ultimate] Pacman Keyring Master Key <pacman@localhost>
[...]

Can you squash the commits?

added 9 commits

• 97988515...76a2fd5e - 2 commits from branch archlinux:master
• c321f472 - Add pacman_keyring init service
• a4b78a46 - enable pacman-init service
• e7879a5e - use "one-liner" syntax
• 5b4069a2 - remove generated keyring in the installation process
• de4243bc - move pacman-init.service to files
• 30858540 - use copy instead of template
• efbfb89c - make sure /etc/machine-id is absent

Compare with previous version

added 1 commit

• 6540e6e8 - Add pacman_keyring init service

Compare with previous version

resolved all threads

Nitpick: Can your follow our convention for commit messages? (<role>: <summary>), also a commit message should describe what changed and why not how (we can look at the diff for that).

https://chris.beams.io/posts/git-commit/ has some good guidelines for writing a good commit message :)

added 1 commit

• 40cf4e6f - install_arch: init pacman keyring on first boot

Compare with previous version

resolved all threads

added 42 commits

• 40cf4e6f...0eb8565a - 41 commits from branch archlinux:master
• 29480b9a - install_arch: init pacman keyring on first boot

Compare with previous version

added 15 commits

• 29480b9a...69bb5a94 - 14 commits from branch archlinux:master
• aa07deaf - install_arch: init pacman keyring on first boot

Compare with previous version

added 4 commits

• aa07deaf...d0de4aa3 - 3 commits from branch archlinux:master
• 34e9d54c - install_arch: init pacman keyring on first boot

Compare with previous version

added 144 commits

• 34e9d54c...9cca4439 - 143 commits from branch archlinux:master
• 3a395f77 - install_arch: init pacman keyring on first boot

Compare with previous version

added 43 commits

• 3a395f77...e0e52552 - 42 commits from branch archlinux:master
• 00cafde1 - install_arch: init pacman keyring on first boot

Compare with previous version

merged

mentioned in commit 8c51c64f

This took way too long to get merged, but with a fix for that Ansible provisioner bug (ec52eb09, thanks @foutrelis), I finally got around to test it.

Good work @aminvakil :)