Skip to content
Snippets Groups Projects

install_arch: align partition end, update root partition type, partition labels and ESP volume label

Merged nl6720 requested to merge nl6720/infrastructure:sgdisk-I into master
All threads resolved!

install_arch: align partition end

sgdisk does not align the partition size/end by default. The -I/--align-end option needs to be used to enable alignment. See https://wiki.archlinux.org/title/Advanced_Format#Partition_alignment

Additionally use the partition names (PARTLABELs) that gdisk and cgdisk set (but sgdisk doesn't) and follow the Discoverable Partitions Specification by useing the appropriate partition for the root partition. See https://wiki.archlinux.org/title/Partitioning#Single_root_partition

install_arch: improve the ESP file system label

Use an uppercase LABEL to avoid a warning from mkfs.fat:

mkfs.fat: Warning: lowercase labels might not work properly on some systems

Use something other than "efi" as the label since some firmware do not like it. While this is not really an issue for Arch infrastructure, since there is zero change that this will be run on any MSI hardware with its broken firmware, it is best to simply folow the wiki anyway. See https://wiki.archlinux.org/title/EFI_system_partition#Firmware_does_not_see_the_EFI_directory

install_arch: create all partitions with a single sgdisk command

There is no need to split up partitioning into per-partition tasks.

Edited by nl6720

Merge request reports

Pipeline #100646 passed

Pipeline passed for 4fbcb12e on nl6720:sgdisk-I

Approval is optional

Merged by Kristian KlausenKristian Klausen 9 months ago (Jun 9, 2024 4:26pm UTC)

Merge details

  • Changes merged into master with ee2a0608.
  • Deleted the source branch.

Pipeline #100648 passed

Pipeline passed for ee2a0608 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nl6720 added 21 commits

    added 21 commits

    • 6ebfeb15...5042d180 - 19 commits from branch archlinux:master
    • 1eb41b01 - roles/install_arch/tasks/main.yml: align partition end
    • 2faf2a43 - roles/install_arch/tasks/main.yml: improve the ESP file system label

    Compare with previous version

  • nl6720 added 2 commits

    added 2 commits

    • 24009f67 - install_arch: align partition end
    • fe66da19 - install_arch: improve the ESP file system label

    Compare with previous version

  • nl6720 changed title from roles/install_arch/tasks/main.yml: align partition end, update root partition type, partition labels and ESP volume label to install_arch: align partition end, update root partition type, partition labels and ESP volume label

    changed title from roles/install_arch/tasks/main.yml: align partition end, update root partition type, partition labels and ESP volume label to install_arch: align partition end, update root partition type, partition labels and ESP volume label

  • nl6720 changed the description

    changed the description

  • nl6720 added 1 commit

    added 1 commit

    • df8aef39 - install_arch: create all partitions with a single sgdisk command

    Compare with previous version

  • nl6720 resolved all threads

    resolved all threads

  • nl6720 changed the description

    changed the description

  • Author Contributor

    The only thing I'm not sure are the quotes in the sgdisk command. Does ansible support it?

  • nl6720 added 1 commit

    added 1 commit

    • 3c4a1925 - install_arch: create all partitions with a single sgdisk command

    Compare with previous version

  • nl6720 resolved all threads

    resolved all threads

  • nl6720 added 1 commit

    added 1 commit

    • 4fbcb12e - install_arch: create all partitions with a single sgdisk command

    Compare with previous version

  • mentioned in commit ee2a0608

  • merged manually

  • I just tested with packer and a new VM. It seems to be working as intended.

    Thanks for the work @nl6720! :)

  • Please register or sign in to reply
    Loading