Properly audit, document and fixup add_foo builderror handling
Forwarded from: #218 (comment 131245)
Basically, currently there is a trap which triggers on add_*
functions, that increments the builderrors global that results in an WARNING at the end of the generation. There are a few things to unpack here:
- document the behaviour - looking through 1000+ of shell script to find the line isn't great
- the current implementation is seemingly buggy, where in some cases the trap will not trigger
- one ^^ is fixed, add a flag
--non-error
to the add_modules API, to omit the builderror handling - if the ^^ fix flags new warnings/errors audit and use the new flag as applicable
- the alternative is to group
add_*
invocations, so that at least one module is added, ultimately silencing the warn/err
- the alternative is to group