Skip to content
Snippets Groups Projects

fix version defs

Closed fix version defs
rmsc/cilium-cli:main into main
1 unresolved thread
Closed Renato Caldas requested to merge rmsc/cilium-cli:main into main
1 unresolved thread

This brings the version strings defined through 'go build -ldflags' up to date with upstream.

The CLI version definition in the PKGBUILD has been broken for a while, but 1.16.17 introduced a new definition for the default image that broke actual 'cilium-cli install':

$ cilium-cli install
strconv.ParseUint: parsing "": invalid syntax

Reference: https://github.com/cilium/cilium-cli/issues/2795

Merge request reports

Approval is optional

Closed by Morten LinderudMorten Linderud 3 months ago (Dec 7, 2024 1:42pm UTC)

Merge details

  • The changes were not merged into main.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Morten Linderud
    Morten Linderud @foxboron started a thread on the diff
    • PKGBUILD
    2 2
    3 3 pkgname=cilium-cli
    4 4 pkgver=0.16.20
    5 pkgrel=1
    5 pkgrel=2
    6 # default cilium version from https://raw.githubusercontent.com/cilium/cilium/main/stable.txt
    7 ciliumver=1.16.4
  • Morten Linderud
    Morten Linderud @foxboron ·
    Developer

    I've submitted an upstream bug report. They should not be pulling from a moving target for this.

    https://github.com/cilium/cilium-cli/issues/2870

  • Renato Caldas added 1 commit

    added 1 commit

    Compare with previous version

  • Morten Linderud
    Morten Linderud @foxboron ·
    Developer

    Closing this PR as the latest release removed the need for this variable. Thanks!

  • Morten Linderud closed

    closed

    • Please register or sign in to reply