Various suggestions/rework from upstream
Task Info (Flyspray) | |
---|---|
Opened By | Emil (xexaxo) |
Task ID | 79382 |
Type | Feature Request |
Project | Arch Linux |
Category | Packages: Extra |
Version | None |
OS | All |
Opened | 2023-08-15 11:07:14 UTC |
Status | Assigned |
Assignee | Sébastien Luttringer (seblu) |
Details
Description:
As mentioned in my upstream MR [1], there are some bits that we can do today:
- the 4 year old PKGBUILD.26 can be removed
- the moddir patching aka s,/lib/modules,/usr/lib/modules,g should be dropped - we don't patch kmod either
- BASHDIR can be dropped, it's the default
The second to last one - SBIN, KCONF and LIBDIR are relative to DESTDIR so they should be updated - would need to follow-up as we get a new release.
With my upstream maintainer hat on, I would love to see hook.sh to become a simple wrapper, although I did not have the time to RE what it's aiming to do :-) My gut suggests that most of it can be replaced by dkms autoinstall.
Additional info:
-
package version(s) 3.0.11-1
-
link to upstream bug report, if any [1] https://github.com/dell/dkms/pull/339
Steps to reproduce:
- drop the PKGBUILD.26, BASHDIR and moddir mangling
- rebuild the package
- observe it still works as expected