Skip to content

Enable error reporting.

Lubosz Sarnecki requested to merge lubosz/hip-runtime-amd:enable-error-reporting into main

By default, clr does not report Errors since it's log level is set to 0.

This can be set with the environment variable AMD_LOG_LEVEL, the default behavior should be to show errors and suppress more verbose logging. I honestly did not know this environment variable, naively thinking there is only MIOPEN_LOG_LEVEL, which I had set to report errors.

I have spent more time that I like to admit to debug an error in Pytorch to figure out what was going on, to notice that hipamd was already checking for that error, just suppressing it's print.

This patch sets the default log level to error. Making redundant log not being printed and really really helpful log being printed.

The second patch is only needed if we keep -DCMAKE_BUILD_TYPE=None. Not sure why this is set, but it leads to DEBUG being defined in the code and producing more verbose logging than useful. Is there a reason why this package is not built on -DCMAKE_BUILD_TYPE=Release?

Btw, not setting CMAKE_BUILD_TYPE defaults to Release:

https://github.com/ROCm/clr/blob/rocm-6.0.x/CMakeLists.txt#L36

Edited by Lubosz Sarnecki

Merge request reports