Undefined symbol in libnixstore.so due to ABI break in AWS SDK

Description:

Version 1.11.486 of the AWS SDK for C++ added an optional parameter to TransferManager::UploadFile. This breaks the ABI of libaws-cpp-sdk-transfer.so and causes an undefined symbol error with programs that link to libnixstore.so:

$ nix-channel --help
nix-channel: symbol lookup error: /usr/lib/libnixstore.so: undefined symbol: _ZN3Aws8Transfer15TransferManager10UploadFileERKSt10shared_ptrISdERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESD_SD_RKSt3mapISB_SB_St4lessISB_ESaISt4pairISC_SB_EEERKS2_IKNS_6Client18AsyncCallerContextEE

I've reported this to the AWS SDK repository but it should also be fixable by rebuilding the nix package since the change is API compatible.

Additional info:

• package version(s): nix 2.24.11-6, aws-sdk-cpp-s3 1.11.488-1
• config and/or log files:
• link to upstream bug report, if any: https://github.com/aws/aws-sdk-cpp/issues/3258

Steps to reproduce:

1. Attempt to run any program that links to libnixstore.so, e.g. nix-channel

added priority3-normal severity4-low statusunconfirmed labels

assigned to @freswa, @alerque, @toolybird, and @gromit

removed statusunconfirmed label

added statusunconfirmed label

added statusconfirmed label and removed statusunconfirmed label

assigned to @grawlinson and unassigned @freswa, @toolybird, and @gromit

Somewhat unexpectedly, the nix package can't be rebuilt at all right now. I suspect the culprit is new compiler tooling that has landed recently, but I don't have time this moment to dig into why. MRs welcome if anybody figures it out, otherwise I'll dig into it when I can.

@bugbuddy assign @carsme @anatolik

assigned to @anatolik and @carsme

It seems like the nix package is the only one affected by this ABI breakage:

$ pkggrep _ZN3Aws8Transfer15TransferManager10UploadFileERKSt10shared_ptrISdERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESD_SD_RKSt3mapISB_SB_St4lessISB_ESaISt4pairISC_SB_EEERKS2_IKNS_6Client18AsyncCallerContextEE    
/srv/ftp/pool/packages/aws-sdk-cpp-s3-1.11.488-1-x86_64.pkg.tar.zst
aws-sdk-cpp-s3
/srv/ftp/pool/packages/nix-2.24.11-6-x86_64.pkg.tar.zst
nix
/srv/ftp/pool/packages/nix-2.24.11-7-x86_64.pkg.tar.zst
nix

@alerque Was the error message related to lowdown? This is the error I saw:

src/libcmd/markdown.cc: In function ‘std::string nix::doRenderMarkdownToTerminal(std::string_view)’:
src/libcmd/markdown.cc:28:5: error: ‘lowdown_opts’ has no non-static data member named ‘cols’
   28 |     };
      |     ^

This is caused by a newer lowdown version and was subsequently fixed in a PR. But the newer version relies on libgit2 1.9 (which is currently in staging).

Yeah that's what I also found, but so far I was not able to fix the build failure by backporting the mentioned fix Will continue to look into this

So the issue was that the upstream has switched their buildsystem in the meantime and therefore the define was not set. I have now dirtily hardcoded it

Currently uploading a fixed package (See bfb9988f for the fix)

Thanks for the quick fix, @gromit!

mentioned in commit 94109802

closed

added resolutioncompleted label

assigned to @bertptrs

FYI this is the response from the AWS C++ SDK GitHub issue:

https://github.com/aws/aws-sdk-cpp/issues/3258#issuecomment-2602636052

The CPP SDK is not ABI stable. If you want ABI stability as feature of the SDK please make a feature request to require ABI stability. right now the recommended way to consume the SDK is building from source