Skip to content
Snippets Groups Projects
Orhun Parmaksız's avatar
accepted merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic
Orhun Parmaksız's avatar
  • a1730129 · Add Desktop Entry and Icon to PKGBUILD
Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

All good, thanks!

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Now the PR should be good @orhun, plus we are using the new release v0.3.4....

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Done in 45beff24

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Done in 22237f4a

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Done in 725aa7e0

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Amazing thanks for the info, I will try it now!

Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

The package source (i.e. archive/v$pkgver.tar.gz) should contain those assets. If not, we need a new release of plastic or you can patch the package.

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

No problem, but I don't understand how we can access those assets then in the PKGBUILD. Could you explain how? Thanks!

Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Can you remove this file?

Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

Please do not compress the man page, it is automatically handled via pacman :)

Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

These assets should be removed.

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

I tested to build the package with a test release of the PR#44 fork and it works.

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

I created a PR with the change: https://github.com/Amjad50/plastic/pull/44

Marcel Arie's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

The image is available in the release but not the package folder that contains the .desktop file.

Orhun Parmaksız's avatar
commented on merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic

These assets should be added to the upstream repository and the Arch package should simply install them.

Marcel Arie's avatar
opened merge request !1 "Add Desktop Entry and Icon to PKGBUILD" at Arch Linux / Packaging / Packages / plastic