Fails to build due to cloe update

This update to cleo or the previous breaks poetry python-cleo@8066ff15 and see also this cleo update revert https://github.com/python-poetry/poetry/pull/9859

Please fix, as this blocks the Python 3.13 rebuild

Successfully built poetry-1.8.5-py3-none-any.whl
Traceback (most recent call last):
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 316, in run
    exit_code = self._run(io)
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/lib/python3.13/site-packages/poetry/console/application.py", line 190, in _run
    exit_code: int = super()._run(io)
                     ~~~~~~~~~~~~^^^^
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 420, in _run
    exit_code = self._run_command(command, io)
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 462, in _run_command
    raise error
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 446, in _run_command
    exit_code = command.run(io)
  File "/usr/lib/python3.13/site-packages/cleo/commands/base_command.py", line 117, in run
    return self.execute(io) or 0
           ~~~~~~~~~~~~^^^^
  File "/usr/lib/python3.13/site-packages/cleo/commands/command.py", line 61, in execute
    return self.handle()
           ~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/cleo/commands/completions_command.py", line 129, in handle
    self.line(self.render(shell))
              ~~~~~~~~~~~^^^^^^^
  File "/usr/lib/python3.13/site-packages/cleo/commands/completions_command.py", line 135, in render
    return self.render_bash()
           ~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/cleo/commands/completions_command.py", line 189, in render_bash
    for cmd in sorted(self.application.all().values(), key=lambda c: c.name or ""):
                      ~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 282, in all
    if name not in commands and self.has(name):
                                ~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 221, in has
    self._command_loader.has(name) and self.add(self._command_loader.get(name))
                                                ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/usr/lib/python3.13/site-packages/cleo/loaders/factory_command_loader.py", line 32, in get
    return self._factories[name]()
           ~~~~~~~~~~~~~~~~~~~~~^^
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/lib/python3.13/site-packages/poetry/console/application.py", line 44, in _load
    module = import_module("poetry.console.commands." + ".".join(words))
  File "/usr/lib/python3.13/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1026, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/lib/python3.13/site-packages/poetry/console/commands/export.py", line 3, in <module>
    from poetry_plugin_export.command import (  # type: ignore[import-untyped]
        ExportCommand as BaseExportCommand,
    )
ModuleNotFoundError: No module named 'poetry_plugin_export'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/bin/poetry", line 8, in <module>
    sys.exit(main())
             ~~~~^^
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/lib/python3.13/site-packages/poetry/console/application.py", line 411, in main
    exit_code: int = Application().run()
                     ~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/cleo/application.py", line 327, in run
    self.render_error(e, io)
    ~~~~~~~~~~~~~~~~~^^^^^^^
  File "/build/python-poetry/src/poetry-1.8.5/test_dir/usr/lib/python3.13/site-packages/poetry/console/application.py", line 180, in render_error
    self.set_solution_provider_repository(self._get_solution_provider_repository())
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Application' object has no attribute 'set_solution_provider_repository'. Did you mean: '_get_solution_provider_repository'?
==> ERROR: A failure occurred in build().
    Aborting...
==> ERROR: Build failed, check /var/lib/archbuild/extra-staging-x86_64/jelle-10/build

added priority3-normal severity4-low statusunconfirmed labels

assigned to @freswa, @alerque, @toolybird, and @gromit

The upstream cleo commit that causes the breakage is 0613be1 Remove crashtest (#438).

poetry-1.8.5

Clarity -> 1.8.4-1 is currently in the repos.

added scopebug statusconfirmed labels and removed statusunconfirmed label

unassigned @freswa, @toolybird, and @gromit

I can no longer reproduce the issue in python-poetry 1.8.4-2 and python-cleo 2.2.1-2. Update: The issue was still reproducible by running poetry env list as of python-cleo 2.2.1-2. The issue went away with python-cleo 1:2.1.0-1 from extra-testing.

@jelle 1. Out of curiosity, how did you manage to fix this? I don’t see any changes other than the Python 3.13 upgpkg.

2. Considering that it works now, should this issue be closed?

The issue is still present, as it seems like the versoin that was now shipped in the repos was built with the --nocheck flag to disable tests

You should be able to repro the bug like so:

$ pkgctl repo clone --protocol https python-poetry
$ pkgctl build python-poetry

So if anybody has the time and energy to look into this it would of course be appreciated!

I suspect what we need to do is patch --verse the offending commits out of python-cleo and release that so that poetry can be updated. I just tried this but the offending commit doesn't reverse cleanly as there are some project manifest conflicts. If anybody wants to take a stab at it in an MR that would be cool. If that fails I suppose the next attempt would be to downgrade it with an epoch.

Ignoring the conflicts with:

    patch -Rp1 -i ../0613be1e064e4015c62f24803300bfab084619fd.patch -F3 || true
    rm src/cleo/ui/exception_trace/__init__.py

The remaining unresolved hunk poetry.lock.rej:

--- poetry.lock
+++ poetry.lock
@@ -1356,4 +1346,4 @@ testing = ["big-O", "flake8 (<5)", "jaraco.functools", "jaraco.itertools", "more
 [metadata]
 lock-version = "2.0"
 python-versions = "^3.7"
-content-hash = "e0ad446826807bc0c0e53172b352abcfe55a3063ce5ea56c57a86906bfefc79b"
+content-hash = "99e188820ea9b593c65e9e260af8dfe70c19299938075726d30d1a3cc566c9fe"

As Arch relaxes version constraints and is not building a locked build can this hunk not being reversed be ignored?

Edit:

Alternative that allows all the hunks to revert cleanly at the expense of reverting two more commits so there may be little difference to the epoch revert content wise.

    filterdiff -p1 -x 'news/*' --clean ../6b3875975097f96748c97bf2a052734b15561692.patch | patch -Rp1
    filterdiff -p1 -x 'news/*' --clean ../efdcd4d13b64a44996ee81e3cc92c924560cb4bc.patch | patch -Rp1
    filterdiff -p1 -x 'news/*' --clean ../0613be1e064e4015c62f24803300bfab084619fd.patch | patch -Rp1
    rm src/cleo/ui/exception_trace/__init__.py

Considering that upstream has yanked all 2.2.x versions due to this bug, maybe downgrading is the correct way to handle it, either by bumping the epoch (as @alerque suggested) or by doing something as ugly as 2.2.1.really.2.1.0-1 (like Debian would do).

mentioned in commit python-cleo@3ff96d93

I just downgraded cleo with an epoch and upgraded poetry/poetry-core. All 3 are in [extra-testing] now. If somebody can give that set a shake down I'd appreciate it. That should resolve this issue completely (until the next upstream snafu).

@alerque Just the epoch-graded python-cleo from extra-testing already fixes the issue for me. In combination with that, the upgraded poetry-core works perfectly fine, too.

Thanks for the down- and upgrade!

closed

added resolutioncompleted label