Skip to content

PKGBUILD suggestions

loqs requested to merge loqs/wvdial:FS#70648 into main
  • Drop unused makedepends lockdev.
  • Fix build failure without !buildflags.
    • This is caused by --as-needed in LDFLAGS and incorret ordering of link options in the Makefile. Fixed with a patch from Debian 1 that moves the libraries to linked with from LDFLAGS to the LIBS in Makefile.in.
  • Fix build failure without !makeflags.
    • Patch from Gentoo 2.
  • Add DESTDIR support to wvdial's Makefile.
    • Patch from Gentoo 3.
  • Add CPPOPTS="$CPPFLAGS -D_DEFAULT_SOURCE" to make invocation.
    • _BSD_SOURCE has been depracted in glibc since 2.20 4 and any compilation unit including a header from glibc will trigger a warning because _BSDSOURCE is defined in wvdial's CPPFLAGS. Define _DEFAULT_SOURCE which is the replacement for _BSD_SOURCE and prevents the warning.

Related to lockdev#1 (closed)

Merge request reports