-
- Downloads
generic bug: use show_regs() instead of dump_stack()
The current generic bug implementation has a call to dump_stack() in case a WARN_ON(whatever) gets hit. Since report_bug(), which calls dump_stack(), gets called from an exception handler we can do better: just pass the pt_regs structure to report_bug() and pass it to show_regs() in case of a warning. This will give more debug informations like register contents, etc... In addition this avoids some pointless lines that dump_stack() emits, since it includes a stack backtrace of the exception handler which is of no interest in case of a warning. E.g. on s390 the following lines are currently always present in a stack backtrace if dump_stack() gets called from report_bug(): [<000000000001517a>] show_trace+0x92/0xe8) [<0000000000015270>] show_stack+0xa0/0xd0 [<00000000000152ce>] dump_stack+0x2e/0x3c [<0000000000195450>] report_bug+0x98/0xf8 [<0000000000016cc8>] illegal_op+0x1fc/0x21c [<00000000000227d6>] sysc_return+0x0/0x10 Acked-by:Jeremy Fitzhardinge <jeremy@goop.org> Acked-by:
Haavard Skinnemoen <hskinnemoen@atmel.com> Cc: Andi Kleen <ak@suse.de> Cc: Kyle McMartin <kyle@parisc-linux.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Paul Mundt <lethal@linux-sh.org> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by:
Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- arch/avr32/kernel/traps.c 1 addition, 1 deletionarch/avr32/kernel/traps.c
- arch/i386/kernel/traps.c 1 addition, 1 deletionarch/i386/kernel/traps.c
- arch/parisc/kernel/traps.c 1 addition, 1 deletionarch/parisc/kernel/traps.c
- arch/powerpc/kernel/traps.c 1 addition, 1 deletionarch/powerpc/kernel/traps.c
- arch/ppc/kernel/traps.c 1 addition, 1 deletionarch/ppc/kernel/traps.c
- arch/s390/kernel/traps.c 1 addition, 1 deletionarch/s390/kernel/traps.c
- arch/sh/kernel/traps.c 1 addition, 1 deletionarch/sh/kernel/traps.c
- arch/x86_64/kernel/traps.c 1 addition, 1 deletionarch/x86_64/kernel/traps.c
- include/linux/bug.h 5 additions, 2 deletionsinclude/linux/bug.h
- lib/bug.c 3 additions, 2 deletionslib/bug.c
Loading
Please register or sign in to comment