-
- Downloads
Remove blkdev warning triggered by using md
As setting and clearing queue flags now requires that we hold a spinlock on the queue, and as blk_queue_stack_limits is called without that lock, get the lock inside blk_queue_stack_limits. For blk_queue_stack_limits to be able to find the right lock, each md personality needs to set q->queue_lock to point to the appropriate lock. Those personalities which didn't previously use a spin_lock, us q->__queue_lock. So always initialise that lock when allocated. With this in place, setting/clearing of the QUEUE_FLAG_PLUGGED bit will no longer cause warnings as it will be clear that the proper lock is held. Thanks to Dan Williams for review and fixing the silly bugs. Signed-off-by:NeilBrown <neilb@suse.de> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Alistair John Strachan <alistair@devzero.co.uk> Cc: Nick Piggin <npiggin@suse.de> Cc: "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Jacek Luczak <difrost.kernel@gmail.com> Cc: Prakash Punnoor <prakash@punnoor.de> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
Showing
- block/blk-core.c 2 additions, 3 deletionsblock/blk-core.c
- block/blk-settings.c 7 additions, 1 deletionblock/blk-settings.c
- drivers/md/linear.c 1 addition, 0 deletionsdrivers/md/linear.c
- drivers/md/multipath.c 1 addition, 0 deletionsdrivers/md/multipath.c
- drivers/md/raid0.c 1 addition, 0 deletionsdrivers/md/raid0.c
- drivers/md/raid1.c 3 additions, 1 deletiondrivers/md/raid1.c
- drivers/md/raid10.c 3 additions, 1 deletiondrivers/md/raid10.c
- drivers/md/raid5.c 1 addition, 0 deletionsdrivers/md/raid5.c
Loading
Please register or sign in to comment