Skip to content
  • Theodore Ts'o's avatar
    ext4: Save stack space by removing fake buffer heads · 8dc207c0
    Theodore Ts'o authored
    
    
    Struct mpage_da_data and mpage_add_bh_to_extent() use a fake struct
    buffer_head which is 104 bytes on an x86_64 system, but only use 24
    bytes of the structure.  On systems that use a spinlock for atomic_t,
    the stack savings will be even greater.
    
    It turns out that using a fake struct buffer_head doesn't even save
    that much code, and it makes the code more confusing since it's not
    used as a "real" buffer head.  So just store pass b_size and b_state
    in mpage_add_bh_to_extent(), and store b_size, b_state, and b_block_nr
    in the mpage_da_data structure.
    
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    8dc207c0