Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • linux-rt linux-rt
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Arch LinuxArch Linux
  • Packaging
  • Upstream
  • linux-rtlinux-rt
  • Repository
Switch branch/tag
  • linux-rt
  • sound
  • usb
  • mixer_scarlett_gen2.c
Find file BlameHistoryPermalink
  • Nathan Chancellor's avatar
    ALSA: usb-audio: scarlett2: Fix for loop increment in scarlett2_usb_get_config · 9a7b7ec3
    Nathan Chancellor authored Jun 26, 2021
    Clang warns:
    
    sound/usb/mixer_scarlett_gen2.c:1189:32: warning: expression result
    unused [-Wunused-value]
                            for (i = 0; i < count; i++, (u16 *)buf++)
                                                        ^      ~~~~~
    1 warning generated.
    
    It appears the intention was to cast the void pointer to a u16 pointer
    so that the data could be iterated through like an array of u16 values.
    However, the cast happens after the increment because a cast is an
    rvalue, whereas the post-increment operator only works on lvalues, so
    the loop does not iterate as expected. This is not a bug in practice
    because count is not greater than one at the moment but this could
    change in the future so this should be fixed.
    
    Replace the cast with a temporary variable of the proper type, which is
    less error prone and fixes the iteration. Do the same thing for the
    'u8 *' below this if block.
    
    Fixes: ac34df73 ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion")
    Link: https://github.com/ClangBuiltLinux/linux/issues/1408
    
    
    Acked-by: default avatarGeoffrey D. Bennett <g@b4.vu>
    Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
    Link: https://lore.kernel.org/r/20210627051202.1888250-1-nathan@kernel.org
    
    
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    9a7b7ec3