Skip to content
Snippets Groups Projects

Add conversion from Package to OutputPackageBase

Merged David Runge requested to merge package_to_management_repo into main
All threads resolved!

Implement initialization of OutputPackageBase and OutputPackage using Package.

Fixes #38 (closed)

Relates to #65 (closed)

Edited by David Runge

Merge request reports

Pipeline #21313 passed

Pipeline passed for c92733ce on package_to_management_repo

Test coverage 100.00% (0.00%) from 1 job
Approval is optional

Merged by David RungeDavid Runge 2 years ago (Jun 25, 2022 6:37am UTC)

Merge details

Pipeline #21362 passed

Pipeline passed for c92733ce on main

Test coverage 100.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Runge added 1 commit

    added 1 commit

    • c92733ce - Add conversion from Package to OutputPackageBase and OutputPackage

    Compare with previous version

  • David Runge resolved all threads

    resolved all threads

  • David Runge marked this merge request as ready

    marked this merge request as ready

  • David Runge changed the description

    changed the description

  • Author Developer

    Hm, the only improvement I can think of right now is to maybe add an integration test that covers the full round-trip (package to management repo). Without feeding the right packages and signatures, this would not entail using it for split packages yet (we don't know which those are without hardcoding or first investigating in the management repo).

    An integration test could probably be more cleanly done in the context of #65 (closed) either way.

  • merged

  • Please register or sign in to reply
    Loading