Fix: Make integration tests more robust

This patch introduces a commented-out section which waits for the NetHSM device to be operational before continuing. This makes the venerable sleep 2 call unnecessary and uses a more granular sleep 1 call instead.

Fixes: #23 (closed)

What do you think about it @dvzrv ?

added 1 commit

• e1102b16 - Fix: Make integration tests more robust

Compare with previous version

Yes! Very good!

Here we can also see, that the container may take around three seconds to be available (really depending on load):

https://gitlab.archlinux.org/wiktor/signstar/-/jobs/249369#L667

I wonder if we should set a max timeout though (e.g. maybe 30s or so)?

added 8 commits

• e1102b16...d0600aea - 7 commits from branch archlinux:main
• 753fd94f - Fix: Make integration tests more robust

Compare with previous version

added 1 commit

• 1441d6da - Fix: Make integration tests more robust

Compare with previous version

Looks great!

The above are just minor nitpicks

approved this merge request

added 1 commit

• 4a41ede9 - Fix: Make integration tests more robust

Compare with previous version

reset approvals from @dvzrv by pushing to the branch

resolved all threads

approved this merge request

added 1 commit

• fc766f0f - Fix: Make integration tests more robust

Compare with previous version

reset approvals from @dvzrv by pushing to the branch

added 1 commit

• a453c43d - Fix: Make integration tests more robust

Compare with previous version

Okay, this should be ready for merging.

One more thing I've added is strategically placed set +/-xes which make the log output a bit more readable. See if you think it's a worthwhile addition.

approved this merge request

merged