Skip to content
  • Eli Schwartz's avatar
    Fix more PHP 7.4 warnings · 050b0808
    Eli Schwartz authored and Lukas Fleischer's avatar Lukas Fleischer committed
    The try_login() function documents it returns an array containing an
    'error' key, and our only caller *only* consults the 'error' key. Then
    the function returns null instead of an array, if the login succeeded!
    I question why we bother returning the new SID if we never use it,
    surely we could either return the error or return default null. But, for
    now, I'm just going to fix it to return what it's actually supposed to,
    without changing the API.
    Signed-off-by: default avatarEli Schwartz <>
    Signed-off-by: default avatarLukas Fleischer <>