sodepends: fix listing binaries, check libdepends, libprovides

• This fixes the problem when a library is needed by multiple binaries in a package, and only the last binary was listed, because the previous list was overridden on every scan.
• Check the sonames provided by the package and compare it with provides=() specified in PKGBUILD. Warn if provided but not specified, error if specified but not provided.
• Check the sonames required by the package and compare it with depends=() specified in PKGBUILD. Warn if a package provides a requred soname but not specified, and if a specified soname is not needed.

Namcap/rules/sodepends.py

@@ -35,24 +35,25 @@ from elftools.elf.dynamic import DynamicSection
 
 libcache = {'i686': {}, 'x86-64': {}}
 
-def scanlibs(fileobj, filename, custom_libs):
+def scanlibs(fileobj, filename, custom_libs, sharedlibs, libprovides):
 	"""
 	Find shared libraries in a file-like binary object
 
-	If it depends on a library, store that library's path.
-
-	returns: a dictionary { library => set(ELF files using that library) }
+	If it depends on a library or provides one, store that library's path.
 	"""
 
 	if not is_elf(fileobj):
 		return {}
 
 	elffile = ELFFile(fileobj)
-	sharedlibs = defaultdict(set)
 	for section in elffile.iter_sections():
 		if not isinstance(section, DynamicSection):
 			continue
 		for tag in section.iter_tags():
+			# DT_SONAME means it provides a library; ignore unversioned (mostly internal) libraries
+			if tag.entry.d_tag == 'DT_SONAME' and not tag.soname.endswith('.so'):
+				soname = tag.soname.rsplit('.so', 1)[0] + '.so'
+				libprovides[soname].add(filename)
 			# DT_NEEDED means shared library
 			if tag.entry.d_tag != 'DT_NEEDED':
 				continue
@@ -69,7 +70,6 @@ def scanlibs(fileobj, filename, custom_libs):
 			except KeyError:
 				# We didn't know about the library, so add it for fail later
 				sharedlibs[libname].add(filename)
-	return sharedlibs
 
 def finddepends(liblist):
 	"""
@@ -133,7 +133,8 @@ class SharedLibsRule(TarballRule):
 	name = "sodepends"
 	description = "Checks dependencies caused by linked shared libraries"
 	def analyze(self, pkginfo, tar):
-		liblist = {}
+		liblist = defaultdict(set)
+		libprovides = defaultdict(set)
 		dependlist = {}
 		filllibcache()
 		os.environ['LC_ALL'] = 'C'
@@ -151,7 +152,7 @@ class SharedLibsRule(TarballRule):
 				for n in pkg_so_files:
 					if any(n.startswith(rp) for rp in rpaths):
 						rpath_files[os.path.basename(n)] = n
-			liblist.update(scanlibs(f, entry.name, rpath_files))
+			scanlibs(f, entry.name, rpath_files, liblist, libprovides)
 			f.close()
 
 		# Ldd all the files and find all the link and script dependencies
@@ -173,6 +174,19 @@ class SharedLibsRule(TarballRule):
 					))
 				self.infos.append(("link-level-dependence %s in %s", (pkg, str(files))))
 
+		# Check provided libraries
+		for i in libprovides:
+			if i in pkginfo["provides"]:
+				self.infos.append(("libprovides-satisfied %s %s", (i, str(list(libprovides[i])))))
+				continue
+			self.warnings.append(("libprovides-unsatisfied %s %s", (i, str(list(libprovides[i])))))
+
+		for i in pkginfo["provides"]:
+			if i.endswith('.so') and i not in libprovides:
+				self.errors.append(("libprovides-missing %s", i))
+
+		self.infos.append(("libprovides-by-namcap-sight provides=(%s)", ' '.join(libprovides) ))
+
 		# Check for packages in testing
 		for i in dependlist.keys():
 			p = Namcap.package.load_testing_package(i)