Skip to content
Snippets Groups Projects

Check for shadow stack support.

Closed loqs requested to merge (removed):SHSTK into master
All threads resolved!

Proposed implementation of a check for shadow stack support. #63 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • loqs added 2 commits

    added 2 commits

    • 0705cef3 - ELF file extraction code warrants a dedicated elf_files_from_tar function.
    • c5e7295b - Check for shadow stack support.

    Compare with previous version

  • loqs resolved all threads

    resolved all threads

    • Resolved by Caleb Maclennan

      The content here looks fine to me. I'd be lying if I said I understood it 100%, but what I can check looks good and a little research suggests it makes sense.

      My only nitpick would be that I've been trying to follow the conventional commits scheme to make future releases easier to cut my being able to generate changelogs. If you aren't up to rewriting these commits (git rebase or git revise) I'd be happy to take care of that bit to get this merged, just let me know.

  • Caleb Maclennan approved this merge request

    approved this merge request

  • I actually merged this branch from the command line fixing the commit messages. I'm confused about how GitLab handles this situation. I thought it would mark this as merged, but it did not.

  • Caleb Maclennan resolved all threads

    resolved all threads

  • David Runge mentioned in issue #72

    mentioned in issue #72

  • Please register or sign in to reply
    Loading