Division by zero issue with "pkgctl search"

For some search terms it seems like the Gitlab search API returns zero pages:

$ pkgctl search PKGBUILD                                                                          
📡 Querying GitLab: 1/1 [100%]    /usr/share/devtools/lib/api/gitlab.sh: line 120: 100 * next_page / total_pages : division by 0 (error token is "total_pages ")

This needs to be investigated and we should most likely handle this. Additionally we maybe need to report this as an issue to Gitlab.

added scopebug label

It seems like this has resolved itself with todays gitlab update

closed

Issue has resurfaced, maybe it was only gone due to gitlab search being defunct in general

reopened

Seems like gitlab is omitting the x-total-pages header that we grep for:

		total_pages=$(grep "x-total-pages" "${header}" | tr -d '\r' | awk '{ print $2 }')

$ curl --request GET --get --url 'https://gitlab.archlinux.org/api/v4//groups/archlinux%2fpackaging%2fpackages/search?scope=blobs&per_page=100&page=1' --header "PRIVATE-TOKEN: $(gopass show --password archlinux/pkgctl-token)" --header 'Content-Type: application/json' --data-urlencode 'search=PKGBUILD -path:keys/pgp/*.asc' --silent -I  

HTTP/2 200 
server: nginx
date: Fri, 20 Dec 2024 15:54:55 GMT
content-type: application/json
content-length: 32996
vary: Accept-Encoding
cache-control: max-age=0, private, must-revalidate
etag: W/"8f59b91f987bb5212941709574675712"
link: <https://gitlab.archlinux.org/api/v4/groups/archlinux%2Fpackaging%2Fpackages/search?id=archlinux%2Fpackaging%2Fpackages&page=2&per_page=100&scope=blobs&search=PKGBUILD+-path%3Akeys%2Fpgp%2F%2A.asc>; rel="next", <https://gitlab.archlinux.org/api/v4/groups/archlinux%2Fpackaging%2Fpackages/search?id=archlinux%2Fpackaging%2Fpackages&page=1&per_page=100&scope=blobs&search=PKGBUILD+-path%3Akeys%2Fpgp%2F%2A.asc>; rel="first"
vary: Origin
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-gitlab-meta: {"correlation_id":"01JFJCESZ6H2P7H8R4R9FQQSWQ","version":"1"}
x-next-page: 2
x-page: 1
x-per-page: 100
x-prev-page: 
x-request-id: 01JFJCESZ6H2P7H8R4R9FQQSWQ
x-runtime: 2.099235
x-search-type: advanced
strict-transport-security: max-age=63072000
referrer-policy: strict-origin-when-cross-origin

Seems like this is an upstream gitlab change:

provide a bypass for the 10,000 API kaminari limit - https://gitlab.com/gitlab-org/gitlab/-/issues/436373

So I guess we should just handle the missing of this header on the application layer for now

mentioned in commit 7589d2b9

mentioned in merge request !292 (merged)

mentioned in commit 2a4b4536

mentioned in commit bed2b5db

closed with commit bed2b5db

closed with merge request !292 (merged)