Move backup-related variable defaults from the database roles into the
borg_client role. Also check group membership to guard installation of
database backup helper scripts.

ansible-lint 6.19.0 started complaining about this:

   schema[tasks]: 'become_method' must be one of the currently available
   values: ansible.builtin.runas, ansible.builtin.su,
           ansible.builtin.sudo, ansible.netcommon.enable,
           community.general.doas, community.general.dzdo,
           community.general.ksu, community.general.machinectl,
           community.general.pbrun, community.general.pfexec,
           community.general.pmrun, community.general.sesu,
           community.general.sudosu, containers.podman.podman_unshare

Leonidas Spyropoulos authored 2 years ago and Evangelos Foutras committed 2 years ago

Convert the permissions to strings to avoid octal interpretation.

Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>

C.UTF-8 is installed by default, so we can avoid messing with locale-gen
by using that.

All the postgres servers (excluding matrix due to[1]) have been migrated
with the following commands:
# sudo -u postgres pg_dumpall > d
# sed "s/LOCALE = 'C'/LOCALE = 'C.UTF-8'/" -i d
# systemctl stop postgresql.service
# mv /var/lib/postgres/data{,.old}
$ ansible-playbook --diff -t postgres playbooks/<host>.yml
# sudo -u postgres psql < d

[1] https://github.com/matrix-org/synapse/blob/19a57f4a3710d6c3f7cc9d031e0e59bc2ed3b052/docs/postgres.md#fixing-incorrect-collate-or-ctype

Fix #470

Fixes: 26f289b7 ("Capitalize the first letter of all task names")

ansible-lint 6.5.0 complains about:

  name: All names should start with an
        uppercase letter. (name[casing])

These are used to signal the start of the document in a stream of many
documents. As Ansible only supports one YAML document per file this is
unnecessary. About a third of our YAML documents already lacked these.

All database user passwords have been updated to use scram-sha-256, so
there's no need for backward compatibility with md5.

Also remove the suggestion to call delete_old_cluster.sh; it's now being
created under /tmp and it only contains a command to remove the old data
directory. (We can do the latter ourselves after some time has passed.)

Ensure the correct version is installed and matches $FROM_VERSION.

Commit 8f113698b63b15a4e0a4b15d3ee37238c1d1821d upstream:

  Remove analyze_new_cluster script from pg_upgrade

  Since this script just runs vacuumdb anyway, remove the script and
  replace the instructions to run it with instructions to run vacuumdb
  directly.

Not much point in vimdiff'ing pg_hba.conf and postgresql.conf.

Adapt upgrade_pg.sh to avoid manipulating /var/lib/postgres' structure
as the postgres user. Instead, create a new empty data directory owned
by postgres for initdb to use.

It was using a nonexistent target path when copying the renewed cert and
was not reloading postgresql.service in order for it to reload the certs.

Fix #177

yaml: truthy value should be one of [false, true] (truthy)
yaml: wrong indentation: expected 4 but found 2 (indentation)
yaml: too few spaces before comment (comments)
yaml: missing starting space in comment (comments)
yaml: too many blank lines (1 > 0) (empty-lines)
yaml: too many spaces after colon (colons)
yaml: comment not indented like content (comments-indentation)
yaml: no new line character at the end of file (new-line-at-end-of-file)
load-failure: Failed to load or parse file
parser-error: couldn't resolve module/action 'hosts'. This often indicates a misspelling, missing collection, or incorrect module path.

Jakub Klinkovský authored 4 years ago and Jelle van der Waa committed 4 years ago

Also mask postgresql.service to make sure that other services with
Wants=postgresql.service and Restart=on-failure will not start it again
during the upgrade.

Jakub Klinkovský authored 4 years ago and Jelle van der Waa committed 4 years ago

Full file path is needed for the file existence check. The bug was
caused by commit 0d2e6e50

Only changes to comments.

This seems to be the cause for our memory leak.

https://www.postgresql.org/message-id/flat/16707-f5df308978a55bf8%40postgresql.org

Mostly changes to comments.

This reverts commit 9809d84d.

I forgot our package already does this.

Improves performance on btrfs.

Prevents borg from backing up the database thrice,
 - once as a database dump,
 - once because /var/lib/postgres/data/ is part of the root backup,
 - once because /var/lib/postgres/backup/ is part of the root backup.

Signed-off-by: Florian Pritz <bluewind@xinu.at>