Fix some inconsistencies in ansible playbooks / roles
- Rename systemd module to systemd_service (See https://github.com/ansible/ansible/pull/77644)
- Use 'Start and enable ' in all corresponding systemd_service: tasks
- Migrate 'with_X' to 'loop'
Closes #541 (closed)
Merge request reports
Activity
mentioned in merge request !898 (closed)
- Resolved by Robin Candau
- Resolved by Robin Candau
added 1 commit
- d78f232e - Use the built-in product filter for nested lists
- Resolved by Sven-Hendrik Haase
Is applying FQCN to all modules of interest?
I see the related warning in ansible-lint has been disabled about 2 years ago stating that applying this rule is to be determined. Since then, FQCN have been applied inconsistently (as in, applied here and there but definitely not everywhere).
My 2 cents would be to apply them out of precaution, as recommended by Ansible themself.
I can add a commit to apply FQCN everywhere if you want me to. Let me know :)
Edited by Robin Candau
- Resolved by Robin Candau
reset approvals from @svenstaro by pushing to the branch
- Resolved by Robin Candau
Could you squash the fixup commits to the changes that you proposed initially? I think it makes sense to have each migration a split commit, but also not more than that
added 5 commits
-
d5341da9...ae918867 - 2 commits from branch
archlinux:master
- 78f862f1 - Rename systemd module to systemd_service
- 73369b45 - Use 'Start and enable ' in all corresponding systemd_service: tasks
- a1f0b9d4 - Migrate 'with_X' to 'loop'
Toggle commit list-
d5341da9...ae918867 - 2 commits from branch
assigned to @gromit