Skip to content
Snippets Groups Projects

Fix some inconsistencies in ansible playbooks / roles

Merged Robin Candau requested to merge (removed):fix_inconsistencies_ansible into master

Closes #541 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sven-Hendrik Haase
  • Robin Candau added 1 commit

    added 1 commit

    • d78f232e - Use the built-in product filter for nested lists

    Compare with previous version

  • Robin Candau added 1 commit

    added 1 commit

    • 609a344d - Improve formatting for long nested list

    Compare with previous version

  • Robin Candau added 1 commit

    added 1 commit

    • 3a2681ab - Improve formatting for long nested list

    Compare with previous version

  • Robin Candau resolved all threads

    resolved all threads

    • Author Contributor
      Resolved by Sven-Hendrik Haase

      Is applying FQCN to all modules of interest?

      I see the related warning in ansible-lint has been disabled about 2 years ago stating that applying this rule is to be determined. Since then, FQCN have been applied inconsistently (as in, applied here and there but definitely not everywhere).

      My 2 cents would be to apply them out of precaution, as recommended by Ansible themself.

      I can add a commit to apply FQCN everywhere if you want me to. Let me know :)

      Edited by Robin Candau
  • Sven-Hendrik Haase approved this merge request

    approved this merge request

  • Sven-Hendrik Haase resolved all threads

    resolved all threads

  • Christian Heusel requested changes

    requested changes

  • Robin Candau added 1 commit

    added 1 commit

    • 97cef0a4 - Fix filtering for nested loop lists

    Compare with previous version

  • Robin Candau reset approvals from @svenstaro by pushing to the branch

    reset approvals from @svenstaro by pushing to the branch

  • Robin Candau added 1 commit

    added 1 commit

    Compare with previous version

  • Robin Candau resolved all threads

    resolved all threads

  • Robin Candau added 5 commits

    added 5 commits

    • d5341da9...ae918867 - 2 commits from branch archlinux:master
    • 78f862f1 - Rename systemd module to systemd_service
    • 73369b45 - Use 'Start and enable ' in all corresponding systemd_service: tasks
    • a1f0b9d4 - Migrate 'with_X' to 'loop'

    Compare with previous version

  • assigned to @gromit

  • Christian Heusel approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading