Review the list of dependencies in PKGBUILD

In the past, python-proton-* packages had missing dependencies in PKGBUILD, while proton-vpn-gtk-app's PKGBUILD contains many dependencies which are actually the dependencies of various python-proton-* components.
Now that we have fixed python-proton-*, we can review the list of dependencies of proton-vpn-gtk-app.

---

setup.py:

Click to expand

        "proton-vpn-api-core",
        "pygobject",
        "pycairo",
        "dbus-python",
        "packaging",
        "distro",
        "requests",
        "proton-core"

Upstream's Debian build script:

Click to expand

Depends: ${python3:Depends}, ${misc:Depends}, librsvg2-common, python3-gi, python3-gi-cairo,
    gir1.2-gtk-3.0, python3-proton-vpn-api-core (>= 0.42.1), python3-dbus,
    gir1.2-nm-1.0, gir1.2-notify-0.7, python3-packaging, python3-distro,
    python3-requests, python3-proton-core
Suggests: libayatana-appindicator3-1, gir1.2-ayatanaappindicator3-0.1

Upstream's Fedora build script:

Click to expand

Requires: gtk3
Requires: python3-gobject
Requires: python3-dbus
Requires: python3-proton-vpn-api-core >= 0.39.0
Requires: librsvg2
Requires: python3-packaging

Suggests: libappindicator-gtk3

---

With reference to the above, the following may not be needed:

• python-aiohttp
• python-bcrypt
• python-gnupg
• python-jinja
• python-pynacl
• python-pyopenssl
• python-sentry_sdk
• webkit2gtk

(EDIT) The following dependency is missing:

• libnotify

For python-proton-vpn-local-agent, it can be moved to python-proton-vpn-network-manager (Please refer to python-proton-vpn-network-manager#1 (comment 236110)).

For python-proton-keyring-linux and python-proton-vpn-network-manager, upstream does not define them as dependencies of proton-vpn-gtk-app.
Instead, upstream has a proton-vpn-gnome-desktop meta package (Debian / Fedora) which pulls in proton-vpn-gtk-app, python-proton-keyring-linux, and python-proton-vpn-network-manager.
We can keep these two as proton-vpn-gtk-app's dependencies for simplicity, or we can create a new meta package like the upstream does.

Upstream's Fedora build script suggests libappindicator-gtk3, which is also present in the PKGBUILD as an optional dependency.
At the same time, the Debian one suggests libayatana-appindicator3-1 and gir1.2-ayatanaappindicator3-0.1 (i.e. libayatana-appindicator in Arch Linux).
Maybe we can list both - libayatana-appindicator is maintained and libappindicator-gtk3 is legacy (reference), ProtonVPN will try the legacy one if ayatana indicator is not available.

added priority3-normal severity4-low statusunconfirmed labels

assigned to @freswa, @toolybird, and @gromit

added scopeenhancement statusconfirmed labels and removed statusunconfirmed label

assigned to @ptr1337 and unassigned @freswa, @toolybird, and @gromit

Hi, I recently opened this issue at the Arch forum. As you can read, I was able to solve it by installing libnotify. The individual who helped me suggested that I open an issue here. In my opinion, my issue should just be an example added to this one.

I hope this helps. Thanks.

libnotify is needed since v4.9.1:

https://github.com/ProtonVPN/proton-vpn-gtk-app/compare/v4.8.2...v4.9.1

Note: proton-vpn-gtk-app was v4.8.2 when I opened this issue, therefore my original post did not include this dependency.

Yeah, all I know is after I updated it was broken. I waited about a week and it wasn't fixed so I figured I would go look into it. The reason it never got fixed is probably that very few people do not have libnotify and do have proton-vpn-gtk-app.

changed the description

Please consider opening a merge request with your suggested dependency changes.

I have opened !1.

From what I see, a merge request is opened by getting the private email address and sending it in the Subject and the description as the message. I have done this. Please let me know what else would help.

EDIT: I got the following response:

Unfortunately, your email message to GitLab could not be processed. You are not allowed to perform this action. If you believe this is in error, contact a staff member.

I sent the email to the one generated at the Merge requests link. It looks like: gitlab+archlinux-packaging-packages-proton-vpn-gtk-app-xxxxx-xxxxx-xxxxxxxxxxxxxxxxxxxxxxxxx-merge-request @ archlinux.org

• Fork the proton-vpn-gtk-app repo.
• Make a new branch in the clone.
• Commit changes to that branch.
• From the cloned repo in gitlab you should be prompted to open a merge request.

Yeah, so this is probably silly but where is the fork button? The reason why I went looking and found that email address it gives you over at Merge requests is because I did not see anything for forking. Maybe I still need to set up ssh here before I can have repos?

After logging in, go to https://gitlab.archlinux.org/archlinux/packaging/packages/proton-vpn-gtk-app and you should see a fork button:

As you can see from the above screenshot, I haven't set up SSH - for simple edits like editing a single file, you may find it more convenient to edit the file and create a commit in browser, this way you don't have to set up SSH or clone the repo. (Note: Remember to go to your fork so that you can see and use the Edit button)

mentioned in merge request !1