kodi segfaults on exit
Description:
Not sure whether to file this under kodi or python; kodi segfaults on exit, backtrace refers to libpython.
This happens since either kodi 21 or python 3.12 (both packages released in April).
Additional info:
- package version(s):
kodi 21.0-4
python 3.12.3-1- config and/or log files:
Process 2826 (kodi.bin) of user 420 dumped core.
Core was generated by `/usr/lib/kodi/kodi.bin --standalone'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 0x0000758146172d11 in _PyGCHead_SET_PREV (prev=<optimized out>, gc=<optimized out>) at ./Include/internal/pycore_gc.h:74
74 gc->_gc_prev = ((gc->_gc_prev & ~_PyGC_PREV_MASK) | uprev);
[Current thread is 1 (Thread 0x758102a006c0 (LWP 2856))]
(gdb) backtrace
#0 0x0000758146172d11 in _PyGCHead_SET_PREV (prev=<optimized out>, gc=<optimized out>) at ./Include/internal/pycore_gc.h:74
#1 _PyObject_GC_UNTRACK (op=0x758103f5e890) at ./Include/internal/pycore_object.h:247
#2 PyObject_GC_UnTrack (op_raw=0x758103f5e890) at Modules/gcmodule.c:2242
#3 0x0000758146274f7b in module_dealloc (m=0x758103f5e890) at Objects/moduleobject.c:709
#4 0x0000758146188437 in _Py_Dealloc (op=<optimized out>) at Objects/object.c:2625
#5 Py_DECREF (op=<optimized out>) at ./Include/object.h:705
#6 Py_XDECREF (op=<optimized out>) at ./Include/object.h:798
#7 Py_XDECREF (op=<optimized out>) at ./Include/object.h:795
#8 meth_dealloc (m=0x758103f5f740) at Objects/methodobject.c:170
#9 0x00007581461774e1 in _Py_Dealloc (op=0x758103f5f740) at Objects/object.c:2625
#10 Py_DECREF (op=0x758103f5f740) at ./Include/object.h:705
#11 Py_XDECREF (op=0x758103f5f740) at ./Include/object.h:798
#12 insertdict (interp=0x758134522010, mp=mp@entry=0x75810cda7980, key=key@entry=0x758103f67d30, hash=hash@entry=-2078559206695431833, value=value@entry=0x7581465a9de0 <_Py_NoneStruct>) at Objects/dictobject.c:1319
#13 0x00007581461faf01 in _PyDict_SetItem_Take2 (value=0x7581465a9de0 <_Py_NoneStruct>, key=<optimized out>, mp=<optimized out>) at Objects/dictobject.c:1865
#14 PyDict_SetItem (value=0x7581465a9de0 <_Py_NoneStruct>, key=<optimized out>, op=<optimized out>) at Objects/dictobject.c:1883
#15 _PyModule_ClearDict (d=0x75810cda7980) at Objects/moduleobject.c:656
#16 0x0000758146274b4c in finalize_modules_clear_weaklist (verbose=0, weaklist=0x7580d7dd3340, interp=0x758134522010) at Python/pylifecycle.c:1526
#17 finalize_modules (tstate=tstate@entry=0x75813457f930) at Python/pylifecycle.c:1609
#18 0x00007581462803fe in Py_EndInterpreter (tstate=0x75813457f930) at Python/pylifecycle.c:2199
#19 0x000061870dab0388 in CPythonInvoker::onExecutionDone() ()
#20 0x000061870e5bac1d in non-virtual thunk to CLanguageInvokerThread::OnExit() ()
#21 0x000061870deb9b90 in CThread::Action() ()
#22 0x000061870dec3304 in ??? ()
#23 0x00007581444e0c84 in std::execute_native_thread_routine (__p=0x61872e34d160) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:104
#24 0x00007581442a6ded in start_thread (arg=<optimized out>) at pthread_create.c:447
#25 0x000075814432a0dc in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78Please let me know which further information to provide.
Activity
added priority3-normal severity4-low statusunconfirmed labels
assigned to @jelle, @freswa, @toolybird, and @gromit
I can reproduce this:
[ 4575.452509] LanguageInvoker[31846]: segfault at 7c20097610d0 ip 00007c2037772d11 sp 00007c1fdbdff568 error 4 in libpython3.12.so.1.0[7c203767c000+266000] likely on CPU 9 (core 1, socket 0) [ 4575.452533] Code: ff ff 48 89 ee ff d0 e9 cf fe ff ff 66 66 2e 0f 1f 84 00 00 00 00 00 66 90 f3 0f 1e fa 48 8b 57 f0 48 85 d2 74 26 48 8b 4f f8 <48> 8b 42 08 48 83 e1 fc 83 e0 03 48 09 c8 48 89 11 48 89 42 08 48Message: Process 31776 (kodi.bin) of user 1000 dumped core. Stack trace of thread 31846: #0 0x00007c2037772d11 PyObject_GC_UnTrack (libpython3.12.so.1.0 + 0x172d11) #1 0x00007c2037874f7b n/a (libpython3.12.so.1.0 + 0x274f7b) #2 0x00007c2037788437 n/a (libpython3.12.so.1.0 + 0x188437) #3 0x00007c20377774e1 n/a (libpython3.12.so.1.0 + 0x1774e1) #4 0x00007c20377faf01 _PyModule_ClearDict (libpython3.12.so.1.0 + 0x1faf01) #5 0x00007c2037874b4c n/a (libpython3.12.so.1.0 + 0x274b4c) #6 0x00007c20378803fe Py_EndInterpreter (libpython3.12.so.1.0 + 0x2803fe) #7 0x00005a87f1300388 _ZN14CPythonInvoker15onExecutionDoneEv (kodi.bin + 0xa1b388) #8 0x00005a87f1e0ac1d _ZThn40_N22CLanguageInvokerThread6OnExitEv (kodi.bin + 0x1525c1d) #9 0x00005a87f1709b90 _ZN7CThread6ActionEv (kodi.bin + 0xe24b90) #10 0x00005a87f1713304 n/a (kodi.bin + 0xe2e304) #11 0x00007c2035ae0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #12 0x00007c20358a6ded n/a (libc.so.6 + 0x92ded) #13 0x00007c203592a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 31776: #0 0x00007c20358a34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x00007c20358a6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00005a87f11f576e n/a (kodi.bin + 0x91076e) #3 0x00005a87f201b1e4 _ZN4KODI9WINDOWING7WAYLAND17CWinSystemWayland24PrepareFramePresentationEv (kodi.bin + 0x17361e4) #4 0x00005a87f201b631 _ZThn2024_N4KODI9WINDOWING7WAYLAND29CWinSystemWaylandEGLContextGL17PresentRenderImplEb (kodi.bin + 0x1736631) #5 0x00005a87f134212f _ZN15CRenderSystemGL13PresentRenderEbb (kodi.bin + 0xa5d12f) #6 0x00005a87f162b287 _ZN15CGraphicContext4FlipEbb (kodi.bin + 0xd46287) #7 0x00005a87f18ab906 _ZN12CApplication6RenderEv (kodi.bin + 0xfc6906) #8 0x00005a87f18ab371 _ZN12CApplication3RunEv (kodi.bin + 0xfc6371) #9 0x00005a87f1166751 main (kodi.bin + 0x881751) #10 0x00007c2035839c88 n/a (libc.so.6 + 0x25c88) #11 0x00007c2035839d4c __libc_start_main (libc.so.6 + 0x25d4c) #12 0x00005a87f11d07d5 _start (kodi.bin + 0x8eb7d5) Stack trace of thread 31786: #0 0x00007c20358a34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x00007c20358a5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x00007c2035ad5e61 __gthread_cond_wait (libstdc++.so.6 + 0xd5e61) #3 0x00005a87f1708556 n/a (kodi.bin + 0xe23556) #4 0x00005a87f1e4aaed _ZN12ANNOUNCEMENT20CAnnouncementManager7ProcessEv (kodi.bin + 0x1565aed) #5 0x00005a87f1709b87 _ZN7CThread6ActionEv (kodi.bin + 0xe24b87) #6 0x00005a87f1713304 n/a (kodi.bin + 0xe2e304) #7 0x00007c2035ae0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #8 0x00007c20358a6ded n/a (libc.so.6 + 0x92ded) #9 0x00007c203592a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 31788: #0 0x00007c203592a4e2 epoll_wait (libc.so.6 + 0x1164e2) #1 0x00007c2037f4ae47 n/a (libspa-support.so + 0x14e47) #2 0x00007c2037f3ca21 n/a (libspa-support.so + 0x6a21) #3 0x00007c2037e10bc7 n/a (libpipewire-0.3.so.0 + 0x6abc7) #4 0x00007c20358a6ded n/a (libc.so.6 + 0x92ded) #5 0x00007c203592a0dc n/a (libc.so.6 + 0x1160dc)Quick search gives me this Kodi issue, however the Python PR comments do not give me enough confidence to simply apply this patch.
Please see: https://bbs.archlinux.org/viewtopic.php?id=295750
I built python-3.12.3-1 with the cpython fix called out in the bug report below it fixed the crashing.
https://github.com/anxdpanic/plugin.video.youtube/issues/753
added scopebug statusconfirmed labels and removed statusunconfirmed label
unassigned @freswa, @toolybird, and @gromit
this can also fix weechat#1 (closed)
@jelle I think you should consider to apply upstream pr.
mentioned in issue weechat#1 (closed)
A less impactful fix has been merged at https://github.com/python/cpython/pull/120431, can we consider this one for backport?
-
@ghen - 3.12.4-1 hit [core-testing] a week ago. Is the fix you mentioned above post-3.12.4?
-
Thanks for verifying. I cannot test 3.12.4-1 + the PR you referenced for some time. Do you know that applying it and not applying https://github.com/python/cpython/pull/118618 which I did verify as fixing this issue does in fact, fix the issue?
https://github.com/python/cpython/pull/118618 fixes the issues for me (verified with 3.12.3 and 3.12.4).
https://github.com/python/cpython/pull/120431 still gives me that segfault unfortunately...
-
https://github.com/python/cpython/pull/118618 fixes the issues for me (verified with 3.12.3 and 3.12.4).
I also applied two of the three commits from that PR (omitting the third which modifies
Doc/data/python3.12.abisince it needs a rebase) to python-3.12.4-1 and can confirm your finding that the it fixes the original issue in this report with Kodi. -
Python upstream just closed the PR that fixes this issue with the comment, "Closing since we are not planning to backport this change." See: https://github.com/python/cpython/pull/118618#issuecomment-2206956567
I am not sure what needs to happen to fix the issue reported here (against Kodi) or the others that are affected.
-
Due to account registration being closed, python developer Neil Schemenauer commented in https://github.com/python/cpython/pull/118618 relating to this bug report:
I cannot comment on the gitlab bug (account registration closed). Based on that call stack dump, I would guess it's a similar problem to what WeeChat is encountering. The traceback is starting from Py_EndInterpreter and ending in _PyObject_GC_UNTRACK. I would suggest calling clear on the kodi module(s) before calling Py_EndInterpreter. Module functions have reference cycles and they make interpreter cleanup very complex. There could be a bug in Python or there could be a bug in kodi (e.g. incorrect refcnt inc/dec somewhere). Adding a module dict clear might fix it. See the gist linked from the comment below: https://github.com/python/cpython/issues/116510#issuecomment-2198359199
- Resolved by John
@idevolder - can you please apply this xbmc patch to fix this issue: https://github.com/xbmc/xbmc/commit/0f5db1a5aa5257ae9611fa76dac25cabeeaddf6d
- Last reply by John
added resolutioncompleted label
-
@ghen - can you please re-open this?
Thanks, I was assuming that commit would fix the issue but it did not (I built from Omega-git).
-
With 21.0-7:
Stack trace of thread 1617: #0 0x00007122a196ddd1 PyObject_GC_UnTrack (libpython3.12.so.1.0 + 0x16ddd1) #1 0x00007122a1a85970 n/a (libpython3.12.so.1.0 + 0x285970) #2 0x00007122a1983cbf n/a (libpython3.12.so.1.0 + 0x183cbf) #3 0x00007122a1972e0a n/a (libpython3.12.so.1.0 + 0x172e0a) #4 0x00007122a1a09209 _PyModule_ClearDict (libpython3.12.so.1.0 + 0x209209) #5 0x00007122a1a85586 n/a (libpython3.12.so.1.0 + 0x285586) #6 0x00007122a1a911c5 Py_EndInterpreter (libpython3.12.so.1.0 + 0x2911c5) #7 0x00006544c49b05b8 _ZN14CPythonInvoker15onExecutionDoneEv (kodi.bin + 0xa3d5b8) #8 0x00006544c5538556 _ZThn40_N22CLanguageInvokerThread6OnExitEv (kodi.bin + 0x15c5556) #9 0x00006544c4dec6e8 _ZN7CThread6ActionEv (kodi.bin + 0xe796e8) #10 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #11 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #12 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #13 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1601: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c489c74e n/a (kodi.bin + 0x92974e) #3 0x00006544c56d4a9b _ZN8ActiveAE9CActiveAE7ProcessEv (kodi.bin + 0x1761a9b) #4 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #5 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #6 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #7 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #8 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1618: #0 0x000071229fb1c39d __poll (libc.so.6 + 0x10839d) #1 0x00007122a1083340 n/a (libavahi-common.so.3 + 0x3340) #2 0x00007122a1085ed1 avahi_simple_poll_run (libavahi-common.so.3 + 0x5ed1) #3 0x00007122a10860b1 avahi_simple_poll_iterate (libavahi-common.so.3 + 0x60b1) #4 0x00007122a10862c6 avahi_simple_poll_loop (libavahi-common.so.3 + 0x62c6) #5 0x00007122a108634f n/a (libavahi-common.so.3 + 0x634f) #6 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #7 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1598: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x0000712291c9d47e n/a (iris_dri.so + 0x9d47e) #3 0x0000712291c7b22c n/a (iris_dri.so + 0x7b22c) #4 0x0000712291c9d3ad n/a (iris_dri.so + 0x9d3ad) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1600: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x0000712291c9d47e n/a (iris_dri.so + 0x9d47e) #3 0x0000712291c7b22c n/a (iris_dri.so + 0x7b22c) #4 0x0000712291c9d3ad n/a (iris_dri.so + 0x9d3ad) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1610: #0 0x000071229faf3b87 getdents64 (libc.so.6 + 0xdfb87) #1 0x000071229faf3c17 readdir64 (libc.so.6 + 0xdfc17) #2 0x00007122a0bff741 n/a (libudev.so.1 + 0x19741) #3 0x00007122a0beee99 n/a (libudev.so.1 + 0x8e99) #4 0x00007122a0bf4c95 udev_enumerate_scan_devices (libudev.so.1 + 0xec95) #5 0x00007122a100d2c6 _ZN3CEC23CUSBCECAdapterDetection16FindAdaptersUdevEPNS_22cec_adapter_descriptorEhPKc (li> #6 0x00007122a100e808 _ZN3CEC23CUSBCECAdapterDetection12FindAdaptersEPNS_22cec_adapter_descriptorEhPKc (libcec> #7 0x00007122a0ffe9be _ZN3CEC15CAdapterFactory14DetectAdaptersEPNS_22cec_adapter_descriptorEhPKc (libcec.so.6 > #8 0x00007122a0ff6fee _ZN3CEC7CLibCEC14DetectAdaptersEPNS_22cec_adapter_descriptorEhPKcb (libcec.so.6 + 0x40fe> #9 0x00006544c538e3a8 _ZN11PERIPHERALS17CPeripheralBusCEC17PerformDeviceScanERNS_21PeripheralScanResultsE (kod> #10 0x00006544c5387414 _ZN11PERIPHERALS14CPeripheralBus14ScanForDevicesEv (kodi.bin + 0x1414414) #11 0x00006544c538738c _ZN11PERIPHERALS14CPeripheralBus7ProcessEv (kodi.bin + 0x141438c) #12 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #13 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #14 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #15 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #16 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1603: #0 0x000071229fb1c39d __poll (libc.so.6 + 0x10839d) #1 0x00006544c4a72c85 _ZN15CFDEventMonitor7ProcessEv (kodi.bin + 0xaffc85) #2 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #3 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #4 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1597: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x0000712291c9d47e n/a (iris_dri.so + 0x9d47e) #3 0x0000712291c7b22c n/a (iris_dri.so + 0x7b22c) #4 0x0000712291c9d3ad n/a (iris_dri.so + 0x9d3ad) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1587: #0 0x000071229faa3595 n/a (libc.so.6 + 0x8f595) #1 0x000071229faaa18e n/a (libc.so.6 + 0x9618e) #2 0x00006544c49b1220 _ZN14CPythonInvoker4stopEb (kodi.bin + 0xa3e220) #3 0x00006544c5544033 _ZN22CLanguageInvokerThread4stopEb (kodi.bin + 0x15d1033) #4 0x00006544c553b0ed _ZN24CScriptInvocationManager4StopEib (kodi.bin + 0x15c80ed) #5 0x00006544c50c1ddc _ZN5ADDON20CServiceAddonManager4StopEv (kodi.bin + 0x114eddc) #6 0x00006544c4fb7896 _ZN12CApplication4StopEi (kodi.bin + 0x1044896) #7 0x00006544c4fb80cb _ZN12CApplication20OnApplicationMessageEPN4KODI9MESSAGING13ThreadMessageE (kodi.bin + 0x> #8 0x00006544c4e4b116 _ZN4KODI9MESSAGING21CApplicationMessenger14ProcessMessageEPNS0_13ThreadMessageE (kodi.bi> #9 0x00006544c4e4b39b _ZN4KODI9MESSAGING21CApplicationMessenger15ProcessMessagesEv (kodi.bin + 0xed839b) #10 0x00006544c4fbf8ee _ZN12CApplication7ProcessEv (kodi.bin + 0x104c8ee) #11 0x00006544c4fb0d29 _ZN12CApplication3RunEv (kodi.bin + 0x103dd29) #12 0x00006544c48162b7 main (kodi.bin + 0x8a32b7) #13 0x000071229fa39c88 n/a (libc.so.6 + 0x25c88) #14 0x000071229fa39d4c __libc_start_main (libc.so.6 + 0x25d4c) #15 0x00006544c4876355 _start (kodi.bin + 0x903355) Stack trace of thread 1613: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c4de90fc _ZN6CTimer7ProcessEv (kodi.bin + 0xe760fc) #3 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #4 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #5 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #6 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #7 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1599: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x0000712291c9d47e n/a (iris_dri.so + 0x9d47e) #3 0x0000712291c7b22c n/a (iris_dri.so + 0x7b22c) #4 0x0000712291c9d3ad n/a (iris_dri.so + 0x9d3ad) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1602: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c489c74e n/a (kodi.bin + 0x92974e) #3 0x00006544c56cd846 _ZN8ActiveAE13CActiveAESink7ProcessEv (kodi.bin + 0x175a846) #4 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #5 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #6 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #7 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #8 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1590: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa5ed9 pthread_cond_wait (libc.so.6 + 0x91ed9) #2 0x000071229fcd5e61 __gthread_cond_wait (libstdc++.so.6 + 0xd5e61) #3 0x00006544c4deba59 n/a (kodi.bin + 0xe78a59) #4 0x00006544c557843f _ZN12ANNOUNCEMENT20CAnnouncementManager7ProcessEv (kodi.bin + 0x160543f) #5 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #6 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #7 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #8 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #9 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1608: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6242 pthread_cond_timedwait (libc.so.6 + 0x92242) #2 0x00007122a0fe66f7 _ZN3CEC10CCECClient7ProcessEv (libcec.so.6 + 0x306f7) #3 0x00007122a0fdc65f _ZN10P8PLATFORM7CThread13ThreadHandlerEPv (libcec.so.6 + 0x2665f) #4 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #5 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1612: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c489c74e n/a (kodi.bin + 0x92974e) #3 0x00006544c5371021 _ZN11PERIPHERALS13CEventScanner7ProcessEv (kodi.bin + 0x13fe021) #4 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #5 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #6 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #7 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #8 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1591: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c489c74e n/a (kodi.bin + 0x92974e) #3 0x00006544c4a76c28 _ZN5CLirc7ProcessEv (kodi.bin + 0xb03c28) #4 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #5 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #6 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #7 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #8 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1596: #0 0x000071229fb2a4e2 epoll_wait (libc.so.6 + 0x1164e2) #1 0x00006544c4a7d038 _ZN16CLibInputHandler7ProcessEv (kodi.bin + 0xb0a038) #2 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #3 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #4 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #5 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #6 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1609: #0 0x000071229fb1c39d __poll (libc.so.6 + 0x10839d) #1 0x00006544c4a6170c _ZN11PERIPHERALS17CPeripheralBusUSB13WaitForUpdateEv (kodi.bin + 0xaee70c) #2 0x00006544c4a6db51 _ZN11PERIPHERALS17CPeripheralBusUSB7ProcessEv (kodi.bin + 0xafab51) #3 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #4 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #5 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #6 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #7 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) Stack trace of thread 1611: #0 0x000071229faa34e9 n/a (libc.so.6 + 0x8f4e9) #1 0x000071229faa6552 pthread_cond_clockwait (libc.so.6 + 0x92552) #2 0x00006544c489c74e n/a (kodi.bin + 0x92974e) #3 0x00006544c53873c7 _ZN11PERIPHERALS14CPeripheralBus7ProcessEv (kodi.bin + 0x14143c7) #4 0x00006544c4dec6df _ZN7CThread6ActionEv (kodi.bin + 0xe796df) #5 0x00006544c4df7035 n/a (kodi.bin + 0xe84035) #6 0x000071229fce0c84 execute_native_thread_routine (libstdc++.so.6 + 0xe0c84) #7 0x000071229faa6ded n/a (libc.so.6 + 0x92ded) #8 0x000071229fb2a0dc n/a (libc.so.6 + 0x1160dc) ELF object binary architecture: AMD x86-64 
Could you please try to produce a backtrace with debug symbols? https://gitlab.archlinux.org/-/snippets/3742
-
@eworm - Thought what I posted above did (I had the kodi debug package installed at the time). I am launching kodi from a systemd service so not directly using gbd. Would providing the 23.2M file from this be helpful?
# coredumpctl list TIME PID UID GID SIG COREFILE EXE SIZE Sat 2024-07-06 04:27:48 EDT 205414 989 989 SIGSEGV present /usr/lib/kodi/kodi.bin 23.2M
-
@gromit - I emailed you the file to your private email not knowing if the coredump may expose some personal information due to kodi plugins debugging who knows what from their config files. Did you receive?
After quite a lot of debugging work, I think I found the bug causing Weechat to crash. It looks similar to the crash that Kodi is producing so I hope the same fix will work. See:
https://github.com/python/cpython/pull/124536
There is an additional bug that affected Weechat, only triggering a crash of Python was built with --with-pydebug. That fix is here:
https://github.com/python/cpython/pull/124541
These fixes are both in the process of review. It would be useful to know if they fix the crash for Kodi.
-
Thanks @nascheme - I will apply these one-at-a-time and test for kodi when I get some time. Stay tuned.
FYI, status of bugs: https://github.com/python/cpython/issues/116510#issuecomment-2389454164
As with Weechat, I would suggest looking into if you can set
m_size = 0for the extension(s) that Kodi creates. You might need to use separate module state but it's also possible it just works by changing the-1to0in the module spec.-
@nascheme - I am unfamiliar with what you're suggesting/not a python person. Can you be more specific? Also, do you recommend doing so with the python-3.12.6-1 repo package or with the package I patches with the two PRs you linked above?
The simple thing to do is wait for Python to get the fixes. If you want to avoid the bugs with a Kodi source change, it's possible you can change the "-1" on the line following "static struct PyModuleDef createModule " to be "0" instead. That's the "m_size" value of the module def. Using 0 marks the Python extension module created by Kodo as being safe for multi-init and would avoid these two bugs. However, I'm not sure what Kodi is doing with it's extension is actually safe so there could be additional code changes to Kodi needed (in order to make the module multi-init safe). You could just try it and see if anything breaks.
The modern way to create Python extensions is with m_size >= 0. The -1 (legacy single-phase init style) is the deprecated way. It should still work to do things that way and if it doesn't it's a bug in Python.
-
If you want to avoid the bugs with a Kodi source change, it's possible you can change the "-1" on the line following "static struct PyModuleDef createModule " to be "0" instead.
If a grep for
'static struct PyModuleDef createModule'in the kodi source tree, I found it inxbmc/interfaces/python/PythonSwig.cpp.template882 static struct PyModuleDef createModule 883 { 884 PyModuleDef_HEAD_INIT, 885 "${module.@name}", 886 "", 887 -1, 888 ${module.@name}_methods, 889 nullptr, 890 nullptr, 891 nullptr, 892 nullptr, 893 };You're saying change line 887 to 0 and then build kodi, yes? Should I test that modification with my modified python-3.12.6 (including the two PRs you linked above) or should I test with the Arch repo package for python-3.12.6?
I'm not familiar with the Kodi source code but that looks like the correct and only place that needs a change. Re-building and testing with a Python without the two fixes (e.g. with 3.16.6) would be useful to see if that change avoids the crash bug (should be triggered when the embedded Python interpreter shutdowns).
Deciding if that's a safe change to make is a bit harder. If it runs okay (and you can use Python modules/extensions) then it might be okay. The best would be to review the Kodi extension module source code but that would take someone familiar with Python extensions and also with Kodi.
-
The repo python package still crashed even with building kodi with that modification.
[Oct 2 18:07] LanguageInvoker[1744847]: segfault at 7f1348d610d0 ip 00007f1363b7d941 sp 00007f1327dff0c0 error 4 in libpython3.12.so.1.0[17d941,7f1363a7c000+27d000] likely on CPU 0 (core 0, socket 0) [ +0.000012] Code: 78 f0 ff 85 d2 0f 88 2a 79 f0 ff 4c 8b 73 20 48 8b 53 f0 48 c7 03 00 00 00 00 4c 8b 6b 28 4d 89 f4 48 85 d2 0f 84 07 03 00 00 <48> 8b 42 08 48 8b 73 f8 83 e0 03 48 83 e6 fc 48 09 f0 48 89 16 48
