Skip to content
Snippets Groups Projects

Disable shadow stack linter by default

Merged Caleb Maclennan requested to merge alerque/namcap:improve-shadow-stack-message into master
All threads resolved!

Refs #72 (not closing that to track making the message useful and re-enabling this by default).

Edited by Caleb Maclennan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Developer

    Given that we're about to have a way to disable this rule by default for now (see !58 (merged)), I think I'll put this on hold (draft mode) until we can just disable it by default for now. Then we can put any substantial improvements to the message on a back burner until we have a better suggestion for a message that would be useful.

    Maybe in the future we'll only enable this for language/compiler combinations we expect to support it, and the message could say what to check that would work for those languages. I agree telling people to check CFLAGS for Rust projects where this won't work unless they switch to nightly and an experimental linker isn't actually helpful.

    Edited by Caleb Maclennan
  • Caleb Maclennan marked this merge request as draft

    marked this merge request as draft

  • Caleb Maclennan resolved all threads

    resolved all threads

  • Caleb Maclennan added 6 commits

    added 6 commits

    • e39df12a...5d40aa85 - 4 commits from branch pacman:master
    • ceb97eda - chore: Improve shadow stack error message with flags to check
    • 3408a0af - chore: Disable shadow stack lint by default until compiler tooling catches up

    Compare with previous version

  • Author Developer

    Updated PR to disable the class until compiler tooling catches up enough that we have something useful to point people towards.

  • Caleb Maclennan marked this merge request as ready

    marked this merge request as ready

  • Caleb Maclennan changed title from Draft: Improve shadow stack error message with flags to check to Disable shadow stack linter by default

    changed title from Draft: Improve shadow stack error message with flags to check to Disable shadow stack linter by default

  • Caleb Maclennan requested review from @dvzrv

    requested review from @dvzrv

  • Jelle van der Waa approved this merge request

    approved this merge request

  • Jelle van der Waa unapproved this merge request

    unapproved this merge request

  • Caleb Maclennan added 6 commits

    added 6 commits

    • 3408a0af...6cf04cb8 - 4 commits from branch pacman:master
    • 28b9b2a3 - chore: Improve shadow stack error message with flags to check
    • 90ddef07 - chore: Disable shadow stack lint by default until compiler tooling catches up

    Compare with previous version

  • Caleb Maclennan added 3 commits

    added 3 commits

    • 1ae1a8a7 - 1 commit from branch pacman:master
    • 5d57960f - chore: Improve shadow stack error message with flags to check
    • 851bbc46 - chore: Disable shadow stack lint by default until compiler tooling catches up

    Compare with previous version

  • Author Developer

    @jelle Approved then unapproved 6 seconds later? Was that an accidental approval or accidental unapproval? Any feedback on getting this disabled?

  • Caleb Maclennan mentioned in merge request !59

    mentioned in merge request !59

  • Caleb Maclennan added 4 commits

    added 4 commits

    • 851bbc46...6b197294 - 2 commits from branch pacman:master
    • d83749e6 - chore: Improve shadow stack error message with flags to check
    • fa7174ac - chore: Disable shadow stack lint by default until compiler tooling catches up

    Compare with previous version

  • Caleb Maclennan changed the description

    changed the description

  • Caleb Maclennan requested review from @jelle

    requested review from @jelle

  • Jelle van der Waa approved this merge request

    approved this merge request

  • Caleb Maclennan added 3 commits

    added 3 commits

    • af352454 - 1 commit from branch pacman:master
    • 4ae9607d - chore: Improve shadow stack error message with flags to check
    • 7d2e36db - chore: Disable shadow stack lint by default until compiler tooling catches up

    Compare with previous version

  • Chih-Hsuan Yen mentioned in issue #72

    mentioned in issue #72

  • Please register or sign in to reply
    Loading