Disable shadow stack linter by default
Refs #72 (not closing that to track making the message useful and re-enabling this by default).
Merge request reports
Activity
requested review from @dvzrv
- Resolved by Caleb Maclennan
Given that we're about to have a way to disable this rule by default for now (see !58 (merged)), I think I'll put this on hold (draft mode) until we can just disable it by default for now. Then we can put any substantial improvements to the message on a back burner until we have a better suggestion for a message that would be useful.
Maybe in the future we'll only enable this for language/compiler combinations we expect to support it, and the message could say what to check that would work for those languages. I agree telling people to check CFLAGS for Rust projects where this won't work unless they switch to nightly and an experimental linker isn't actually helpful.
Edited by Caleb Maclennanadded 6 commits
-
e39df12a...5d40aa85 - 4 commits from branch
pacman:master
- ceb97eda - chore: Improve shadow stack error message with flags to check
- 3408a0af - chore: Disable shadow stack lint by default until compiler tooling catches up
-
e39df12a...5d40aa85 - 4 commits from branch
requested review from @dvzrv
added 6 commits
-
3408a0af...6cf04cb8 - 4 commits from branch
pacman:master
- 28b9b2a3 - chore: Improve shadow stack error message with flags to check
- 90ddef07 - chore: Disable shadow stack lint by default until compiler tooling catches up
-
3408a0af...6cf04cb8 - 4 commits from branch
@jelle Approved then unapproved 6 seconds later? Was that an accidental approval or accidental unapproval? Any feedback on getting this disabled?
mentioned in merge request !59
added 4 commits
-
851bbc46...6b197294 - 2 commits from branch
pacman:master
- d83749e6 - chore: Improve shadow stack error message with flags to check
- fa7174ac - chore: Disable shadow stack lint by default until compiler tooling catches up
-
851bbc46...6b197294 - 2 commits from branch
requested review from @jelle
mentioned in issue #72