Skip to content
Snippets Groups Projects

feat: Allow rules to be disabled by default.

Merged loqs requested to merge (removed):disabled-rules into master
1 unresolved thread

This might be useful in relation to #72.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • loqs added 1 commit

    added 1 commit

    • 8fed648d - feat: Allow rules to be disabled by default.

    Compare with previous version

  • loqs resolved all threads

    resolved all threads

  • loqs
  • loqs
  • loqs
    • What is the rationale of this PR? I would rather have a .namcap.toml configuration file which allowed packagers to ignore specific false positive rules.

    • Having that too would be nice, but that doesn't cover the use case that triggered this MR in the first place. We did some work to code up rules that work but turn out to be too aggressive at the current date and we'd like to disable them for all users without getting rid of the code entirely since it will be useful someday (see #72).

    • Please register or sign in to reply
  • Caleb Maclennan added 1 commit

    added 1 commit

    • 327813d6 - chore: Fix minor typo in help message

    Compare with previous version

  • Caleb Maclennan added 3 commits

    added 3 commits

    • 670dde6a - 1 commit from branch pacman:master
    • f9c82c97 - feat: Allow rules to be disabled by default.
    • 5d40aa85 - chore: Fix minor typo in help message

    Compare with previous version

  • Caleb Maclennan approved this merge request

    approved this merge request

  • Caleb Maclennan marked this merge request as ready

    marked this merge request as ready

  • Caleb Maclennan mentioned in merge request !56 (merged)

    mentioned in merge request !56 (merged)

  • Please register or sign in to reply
    Loading