[Feedback] Package Requests
Feedback(Requests)
There have been a lot of changes to the requests system in Python's implementation.
Changes(General)
- All users can now view and close requests which they themselves created.
- The
Accept
link in/requests
no longer navigates to request closure, but directly to the action which satisfies the request. This removes a step for TUs between accepting a request and performing the related action; it's now all tied to the action. - All request-related actions now contain a Comments field, which can be used to set a closure comment for any existing requests that the action satisfies (closes as accepted).
-
/requests/{id}/close
no longer allows you to accept a request; it is purely used for rejection closures. - Deletion and merge actions now autogenerate package requests. This is done to increase tracking of actions taken on the platform.
- Orphan requests are now required to disown as a Trusted User.
- When disowning a package, the maintainer or comaintainer path is preferred over your Trusted User status, in which cases no requests are dealt with.
Bugs(General)
Deletion
Tests - Deletion
Good Path 1
- Logged in as
kevr (User)
on both Python & PHP. - Clicked
Submit Request
on/packages/{name}
, filled out a comment and submitted a deletion request in Python.- An email was sent to aur-requests regarding this request creation.
- Clicked
Submit Request
on/packages/{name}
, filled out a comment and submitted a deletion request in PHP.- An email was sent to aur-requests regarding this request creation.
- Clicked
Close
in/requests
for the PHP request we just created and submitted a closure.- A rejection email was sent to
aur_request_ml
regarding this request closure.
- A rejection email was sent to
- Logged in as
kevr_tu (Trusted User)
on Python. - Clicked
Accept
in/requests
for the Python request we just created, which is a link to/packages/{name}/delete
, since it's a deletion request. - Filled out a closure comment, checked the confirmation box and submitted the deletion form.
- Package was deleted from the database; no longer visible in
/packages
. - An acception email was sent to
aur_request_ml
regarding this request closure with the closure comment I gave in step 7.
Good Path 2
- Logged in as
kevr_tu (Trusted User)
on Python. - Navigated to
/packages/{name}
and clicked theDelete Package
link, which brought me to/pkgbase/{name}/delete
. - Omitted comments, checked the confirmation box and submitted the delete action.
- An acception notification for a deletion request for
{name}
was sent to aur-requests with an autogenerated closure comment. - Navigated to
/requests
and saw the deletion request which was autogenerated for the action I took.
Changes - Deletion
- The
Accept
action on/requests
now links us to/pkgbase/{name}/delete
for deletion requests, which takes care of request records on submission. -
/pkgbase/{name}/delete
now includes a Comments field, which can be filled out to supply a closure comment to any existing or autogenerated request.
Merge
Tests - Merge
Good Path 1
- Navigated to
/packages/{name}
and submitted a merge request to merge intopkg_a
in Python.- An email was sent to aur-requests regarding this request creation.
- Navigated to
/packages/{name}
and submitted a merge request to merge intopkg_b
in PHP.- An email was sent to aur-requests regarding this request creation.
- Navigated to
/requests
and clickedAccept
on the request to merge intopkg_a
, which brought me to/pkgbase/{name}/merge
. - Checked the confirmation box, omitted comments and submitted the merge form.
-
{name}
was merged intopkg_a
. - An acception notification was sent out for the
pkg_a
merge request with an autogenerated body. - A rejection notification was sent out for the
pkg_b
merge request with an autogenerated body.
Good Path 2
- Logged in as
kevr_tu (Trusted User)
on Python. - Navigated to
/packages/{name}
and clicked theMerge Package
link, which brought me to/pkgbase/{name}/merge
. - Omitted comments, filled out
pkg_a
for merge into and checked the confirmation box and submitted the merge action. - An acception notification for a merge request for
{name}
being merged intopkg_a
was sent to aur-requests with an autogenerated closure comment. - Navigated to
/requests
and saw the merge request which was autogenerated for the action I took. - Was redirected to
/pkgbase/{name}
; this is a bug -- we merged this.
Changes - Merge
- The
Accept
action on/requests
now links us to/pkgbase/{name}/merge
for merge requests, which takes care of request records on submission. -
/pkgbase/{name}/merge
now includes a Comments field, which can be filled out to supply a closure comment to any existing or autogenerated request.
Orphan
Tests - Orphan
Good Path
- Navigated to
/packages/{name}
and submitted an orphan request in Python. - Navigated to
/requests
. - We see the orphan request at the top of the list with a
Close
link, but in theAccept
link's place,Locked (~14 days left)
is displayed. - Went into the database and updated the request's
RequestTS
column to 14 days ago - 1 second. - Refreshed
/requests
, now the orphan request has anAccept
link and the Date field is colored red. - Clicking
Accept
brings me to/pkgbase/{name}/disown
- With comments omitted and the confirmation box checked, I submitted
the disown form, then was redirected to
/packages/{name}
, where theMaintainer
field becameNone
. - An acception notification was sent to aur-requests about the closure.
Bad Path
- Navigated to
/pkgbase/{name}
and clickedDisown Package
without creating a request, which brought me to/pkgbase/{name}/disown
. - Omitted comments and checked the confirmation box, then submitted the form.
- An error is displayed:
No due existing orphan requests to accept for ziploc.
Changes - Orphan
- The
Accept
action on/requests
now links us to/pkgbase/{name}/merge
for merge requests, which takes care of request records on submission. -
/pkgbase/{name}/disown
now includes a Comments field, which can be filled out to supply a closure comment to any existing or autogenerated request. - Disowning a package as a Trusted User now requires a pre-existing orphan request.