git+ssh clone is slow

We use poetry in /usr/local/bin/aurweb-git-auth.sh https://gitlab.archlinux.org/archlinux/aurweb/-/blob/master/examples/aurweb-git-auth.sh for ssh git authentication. Running poetry seems to cause an extra 2 seconds delay according to @foutrelis

https://security.stackexchange.com/questions/123795/authorizedkeyscommand-of-sshd-config-getting-called-twice/123801#123801

changed the description

2 seconds of delay for the SSH auth (because sshd calls it twice), probably another second when launching aurweb-git-serve. So a total of 3 seconds startup delay caused by poetry.

marked infrastructure#462 (closed) as a duplicate of this issue

mentioned in issue infrastructure#462 (closed)

changed milestone to %August release 6.1.0

auth.py query on SSHPubKeys table joined with Users table but the WHERE statement has WHERE SSHPubKeys.PubKey = ? and the PubKey column is not indexed. So for each ssh auth we scan the whole sshpubkey table twice.

Fixed in 6c7e2749

added scopeenhancement label

Upstream issue for poetry

infrastructure!612 (merged) fixes the poetry being slow issue by not using it. aurweb-git-auth still takes around ~500ms and like 99% of the time is spent importing aurweb.db.

We could avoid the import cost, by switching to a client/server model (ex: multiprocessing), but that is perhaps too much complexity.

Bit of a hack to avoid importing aurweb.db (and thus aurweb.util and sqlalchemy), but it brings aurweb-git-auth's runtime down to 70 ms (from 1s) in my tests: !500 (closed)

After looking through this, I would've came up with the exact same solution here that @foutrelis did. The bootstrapping of ORM just makes this so much slower.

Your MR looks great; I'll just do some double-triple check on it, but I believe this would be fine.

I don't really consider this to be a hack. It's just using the raw DB connection as was done originally.

mentioned in merge request !500 (closed)

added performance statusin-progress labels

mentioned in merge request infrastructure!612 (merged)

closed with commit 913ce8a4