Skip to content
Snippets Groups Projects

Test mysql & sqlite

Merged Kevin Morris requested to merge kevr/aurweb:pu_mysql_test into pu
All threads resolved!

First off: This commit set changes the default development database backend to mysql. sqlite, however, is still completely supported with the caveat that a user must now modify config.dev to use the sqlite backend.

While looking into this, it was discovered that our SQLAlchemy backend for mysql (mysql-connector) completely broke model attributes when we switched to utf8mb4_bin (binary) -- it does not correct the correct conversion to and from binary utf8mb4.

The new, replacement dependency mysqlclient does. mysqlclient is also recommended in SQLAlchemy documentation as the "best" one available.

The mysqlclient backend uses a different exception flow then sqlite, and so models now raise IntegrityError when it finds problematic nulls (to centralize the exception logic).

In addition, now mysql and sqlite are both tested in CI. Docker hasn't been modified yet due to incoming changes to its config.

Edited by Kevin Morris

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Leonidas Spyropoulos
  • Leonidas Spyropoulos
  • Kevin Morris
  • Kevin Morris added 1 commit

    added 1 commit

    • d6a21f33 - test both mysql and sqlite in .gitlab-ci.yml

    Compare with previous version

  • Kevin Morris resolved all threads

    resolved all threads

  • Kevin Morris added 1 commit

    added 1 commit

    • 75af2ec9 - test both mysql and sqlite in .gitlab-ci.yml

    Compare with previous version

  • Kevin Morris requested review from @jocke-l

    requested review from @jocke-l

  • Kevin Morris added 81 commits

    added 81 commits

    Compare with previous version

  • Author Contributor

    Merge inc.

  • merged

  • Please register or sign in to reply
    Loading