Some of the columns that were changed still want to be
case insensitive. Good thing our tables have nice
separation.

Signed-off-by: Kevin Morris <kevr@0cost.org>

Leonidas Spyropoulos authored 3 years ago and Kevin Morris committed 3 years ago

MySql defaults to `utf8` and case insensitive collation so migrate these to case sensitive and `utf8mb4`

Closes #21

Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com>

Leonidas Spyropoulos authored 3 years ago and Kevin Morris committed 3 years ago

Closes: #34

Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com>

op.drop_constraint requires a valid field to drop the constraint on.
Without this, downgrade cannot occur.

Signed-off-by: Kevin Morris <kevr@0cost.org>

Signed-off-by: Kevin Morris <kevr@0cost.org>

Signed-off-by: Kevin Morris <kevr@0cost.org>

Marcus Andersson authored 3 years ago and Eli Schwartz committed 3 years ago

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

I've seen this happen a bunch of times now. Someone cannot push to the
AUR, and the error report is some traceback with a KeyError which is
difficult to understand without context:

remote: Traceback (most recent call last):
remote:   File "/srv/http/aurweb/aur.git/hooks/update", line 33, in <module>
remote:     sys.exit(load_entry_point('aurweb==5.0.0', 'console_scripts', 'aurweb-git-update')())
remote:   File "/usr/lib/python3.9/site-packages/aurweb-5.0.0-py3.9.egg/aurweb/git/update.py", line 306, in main
remote: KeyError: 'pkgbase'

Eventually it turns out that their .SRCINFO file is... badly corrupted.
Generally, they managed to accidentally commit an *empty* file instead
of a .SRCINFO, and in all cases, the problem was on the very first
lookup for 'pkgbase'.

Point people to the actual failing commit, and have a nicely formatted
message indicating that the .SRCINFO is completely invalid.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Kevin Morris authored 4 years ago and Eli Schwartz committed 3 years ago

uvicorn is subjectively nicer to play with for local dev work, but
hypercorn is required in order to do HTTP/2 which is fairly
performance-important.

Signed-off-by: Kevin Morris <kevr@0cost.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>
Co-authored-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Kristian Klausen authored 3 years ago and Eli Schwartz committed 3 years ago

Done with: find -type f -exec sed -Ee ':wiki.archlinux.org: s:(wiki.archlinux.org)/index.php/:\1/title/:g' -i {} \;

Fixes #16

[1] archlinux/infrastructure!335



Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Mostly here to make sure people continue to use tabbed indents for php
and the TAP tests, since that is what they are currently using.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>

Jelle van der Waa authored 3 years ago and Lukas Fleischer committed 3 years ago

The account deletion code tries to remove user from PackageNotifications
using the wrong column UsersID to identify the user by id. In the
PackagePackageNotifications table the foreign key is called UserID. In
the future ideally this would be unified into UserID for all tables.

Closes: #12
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Felix Yan authored 4 years ago and Lukas Fleischer committed 4 years ago

jsdelivr is another free CDN service for open source projects.

The main motivation for this change is that it is the only one that works fairly
well across the globe. The Google CDN service is known to be hardly
accessible in mainland China, unfortunately.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Fixes GitLab issue #3.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

hashworks authored 4 years ago and Lukas Fleischer committed 4 years ago

I think after 10-15 years we might want to adjust those values. With a
30min cache and 20 items per creation I would bet some new AUR packages
might be swept under the carpet.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

hashworks authored 4 years ago and Lukas Fleischer committed 4 years ago

https://validator.w3.org/feed/docs/warning/MissingGuid.html


Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

hashworks authored 4 years ago and Lukas Fleischer committed 4 years ago

https://validator.w3.org/feed/docs/warning/ImageTitleDoesntMatch.html


Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

hashworks authored 4 years ago and Lukas Fleischer committed 4 years ago

https://validator.w3.org/feed/docs/warning/UnexpectedContentType.html


Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

hashworks authored 4 years ago and Lukas Fleischer committed 4 years ago

https://validator.w3.org/feed/docs/warning/MissingAtomSelfLink.html


Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jakub Klinkovský authored 4 years ago and Lukas Fleischer committed 4 years ago

When the keyword parameter is empty, the AND clause has to be omitted,
otherwise we get an SQL syntax error:

... WHERE PackageBases.PackagerUID IS NOT NULL AND () ...

This got broken in commit 9e30013a
Author: Kevin Morris <kevr.gtalk@gmail.com>
Date:   Sun Jul 5 18:19:06 2020 -0700

Support conjunctive keyword search in RPC interface

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jakub Klinkovský authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jakub Klinkovský authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jakub Klinkovský authored 4 years ago and Lukas Fleischer committed 4 years ago

Of course the default exit code is 0...

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Jakub Klinkovský authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Filipe Laíns authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Filipe Laíns authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Filipe Laíns authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Filipe Laíns authored 4 years ago and Lukas Fleischer committed 4 years ago

This allows using a relative path for the config. PHP didn't play well
with it.

Signed-off-by: Filipe Laíns <lains@archlinux.org>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Introduce a `redirect` query argument to SSO login endpoints so that
users are redirected to the page they were originally on when they
clicked the Login link.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

This feature was originally introduced by
f961ffd9 as a fix for FS#12898
<https://bugs.archlinux.org/task/12898

>.

As of today, it is broken because of the `q.SessionID IS NULL` condition
in the WHERE clause, which can’t be true because SessionID is not
nullable. As a consequence, the session limit was not applied.

The fact the absence of the session limit hasn’t caused any issue so
far, and hadn’t even been noticed, suggests the feature is unneeded.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Error outputs were piped to a temporary buffer that wasn’t read by
anyone, making debugging hard because errors were completely silenced.
By not explicitly redirecting stderr on proc_open, the subprocess
inherits its parent stderr.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Only ttys have a terminal size. If we can’t obtain it, we’ll just use 80
as a sane default.

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Kevin Morris authored 4 years ago and Lukas Fleischer committed 4 years ago

The existing notify.py script was grabbing entries regardless
of user suspension. This has been modified to only send notifications
to unsuspended users.

This change was written as a solution to
https://bugs.archlinux.org/task/65554

.

Signed-off-by: Kevin Morris <kevr.gtalk@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Kevin Morris authored 4 years ago and Lukas Fleischer committed 4 years ago

Newly supported API Version 6 modifies `type=search` for _by_ type
`name-desc`: it now behaves the same as `name-desc` search through the
https://aur.archlinux.org/packages/ search page.

Search for packages containing the literal keyword `blah blah` AND `haha`:
https://aur.archlinux.org/rpc/?v=6&type=search&arg="blah blah"%20haha

Search for packages containing the literal keyword `abc 123`:
https://aur.archlinux.org/rpc/?v=6&type=search&arg="abc 123"

The following example searches for packages that contain `blah` AND `abc`:
https://aur.archlinux.org/rpc/?v=6&type=search&arg=blah%20abc

The legacy method still searches for packages that contain `blah abc`:
https://aur.archlinux.org/rpc/?v=5&type=search&arg=blah%20abc
https://aur.archlinux.org/rpc/?v=5&type=search&arg=blah%20abc

API Version 6 is currently only considered during a `search` of `name-desc`.

Note: This change was written as a solution to
https://bugs.archlinux.org/task/49133

.

PS: + Some spacing issues fixed in comments.

Signed-off-by: Kevin Morris <kevr.gtalk@gmail.com>
Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>

Frédéric Mangano-Tarumi authored 4 years ago and Lukas Fleischer committed 4 years ago

Signed-off-by: Lukas Fleischer <lfleischer@archlinux.org>