If a main key is revoked we do not want to use those keys to count
the required trust threshold.

De-duplicate not needed certifications by cleaning the keyring after
import to remove old files when processing revocations. This basically
adds the functionality compared to import-clean.

Add a postfix hash of the raw uid data to the filenames to avoid
collisions with the simplified uid.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

libkeyringctl/keyring.py:
Simplify `convert_certificate()` by splitting out the conversion of
signature packets to `convert_signature_packet()` and the persistence of
packet material to `persist_key_material()`.
Add `convert_pubkey_signature_packet()`,
`convert_uid_signature_packet()` and
`convert_subkey_signature_packet()` to deal with the conversion of
public key signatures, UID signatures and subkey signatures
(respectively).

tests/test_keyring.py:
Add tests for `convert_certificate()`, `convert_signature_packet()`,
`convert_{pubkey,uid,subkey}_signature_packet()` and
`persist_subkey_revocations()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_keyring.py:
Add tests for `list_keyring()` and `inspect_keyring()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

libkeyringctl/keyring.py:
Change `get_packets_from_path()` to use full conditional statements
which is easier to cover in tests.

tests/test_keyring.py:
Add simple tests for `get_packets_from_path()`,
`get_packets_from_listing()`, `export()` and `build()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_keyring.py:
Add basic tests for `convert()`, `export_ownertrust()` and
`export_revoked()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_sequoia.py:
Add unit test for libkeyringctl.sequoia.packet_kinds.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_keyring.py:
Add tests for `is_pgp_fingerprint()`,
`transform_{fingerprint,username}_to_keyring_path()`,
`derive_username_from_fingerprint()` and get_fingerprints_from_paths()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/conftest.py:
Add `valid_fingerprint()` and `valid_subkey_fingerprint()` fixtures to
produce a generic "valid" PGP fingerprint string.
Add the `invalid_fingerprint()` fixture to generate a set of "invalid"
fingerprint strings.

This avoids collision between same issuer using key-id and full
fingerprint in different versions of a packet, like signature.

CalledProcessError returns bytes for our invocations, the fix that
decoded bytes of stdout was purely to make the mocked test happy while
breaking the actual usage. Restore the behavior and fix the wrong mocked
data.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_util.py:
Add tests for `cwd()`, `natural_sort_path()`, `system()`,
`absolute_path()`, `transform_fd_to_tmpfile()`, `get_cert_paths()`,
`get_parent_cert_paths()` and `contains_fingerprint()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_sequoia.py:
Add unit tests for `keyring_split()`, `keyring_merge()`,
`packet_split()`, `packet_join()`, `inspect()`, `packet_dump()`,
`packet_dump_field()`, `packet_signature_creation_time()`, and
`latest_certification()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/test_git.py:
Add unit test for `git_changed_files()`.

David Runge authored 3 years ago and Levente Polyak committed 3 years ago

tests/*:
The existing coverage configuration is setup to use/ omit a tests
directory.